From: Trond Myklebust Subject: Re: [PATCH] nfs: fix encode_fsinfo_maxsz Date: Thu, 13 Mar 2008 12:21:04 -0400 Message-ID: <1205425264.11399.3.camel@heimdal.trondhjem.org> References: <1205414790-1710-1-git-send-email-bhalevy@panasas.com> Mime-Version: 1.0 Content-Type: text/plain Cc: linux-nfs@vger.kernel.org, Fred Isaman To: Benny Halevy Return-path: Received: from pat.uio.no ([129.240.10.15]:60453 "EHLO pat.uio.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752224AbYCMQVI (ORCPT ); Thu, 13 Mar 2008 12:21:08 -0400 In-Reply-To: <1205414790-1710-1-git-send-email-bhalevy@panasas.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Thu, 2008-03-13 at 15:26 +0200, Benny Halevy wrote: > From: Fred Isaman > > The previous value was not taking into account space for bitmap array size. > > Signed-off-by: Fred Isaman > Signed-off-by: Benny Halevy > --- > fs/nfs/nfs4xdr.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c > index 51dd380..0277821 100644 > --- a/fs/nfs/nfs4xdr.c > +++ b/fs/nfs/nfs4xdr.c > @@ -110,7 +110,7 @@ static int nfs4_stat_to_errno(int); > #define decode_savefh_maxsz (op_decode_hdr_maxsz) > #define encode_restorefh_maxsz (op_encode_hdr_maxsz) > #define decode_restorefh_maxsz (op_decode_hdr_maxsz) > -#define encode_fsinfo_maxsz (op_encode_hdr_maxsz + 2) > +#define encode_fsinfo_maxsz (encode_getattr_maxsz) > #define decode_fsinfo_maxsz (op_decode_hdr_maxsz + 11) > #define encode_renew_maxsz (op_encode_hdr_maxsz + 3) > #define decode_renew_maxsz (op_decode_hdr_maxsz) Thanks! Has this ever been observed to cause problems in the mainline NFSv4? Having never seen any such problems myself, I'm a bit inclined to delay this until the 2.6.26 merge window. That said, if you can point to an instance where it caused a bug, then I'll push it to Linus sooner. Cheers Trond