From: "Steinar H. Gunderson" Subject: Re: retry= is additive with the text-based mount interface Date: Fri, 25 Apr 2008 18:59:21 +0200 Message-ID: <20080425165921.GA7108@uio.no> References: <20080425080535.GA4999@uio.no> <46541DE2-4D6A-4701-A3BB-E609F0E51D6D@oracle.com> <20080425163457.GA6952@uio.no> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: linux-nfs@vger.kernel.org To: Chuck Lever Return-path: Received: from cassarossa.samfundet.no ([129.241.93.19]:42686 "EHLO cassarossa.samfundet.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762377AbYDYQ7X (ORCPT ); Fri, 25 Apr 2008 12:59:23 -0400 In-Reply-To: Sender: linux-nfs-owner@vger.kernel.org List-ID: On Fri, Apr 25, 2008 at 12:45:36PM -0400, Chuck Lever wrote: >> fugl:~# mount -t nfs -v -o retry=0 10.0.0.11:/foo /mnt >> mount.nfs: timeout set for Thu Jan 1 14:40:25 1970 >> mount.nfs: text-based options: 'retry=0,addr=10.0.0.11' > On my test system (Fedora 7) I get correct behavior with both /bin/mount > and when using /sbin/mount.nfs directly. It seems the patch has an issue: + if (!parse_retry_option(&timeout, options, NFS_DEF_FG_TIMEOUT_MINUTES)) where parse_retry_option() _adds_ to timeout. But timeout is not initialized :-) /* Steinar */ -- Homepage: http://www.sesse.net/