From: Peter Staubach Subject: Re: [PATCH 1/3] mount.nfs: fix retry option settings with binary mount options Date: Wed, 09 Apr 2008 17:29:47 -0400 Message-ID: <47FD354B.9020103@redhat.com> References: <1206822608-20154-1-git-send-email-jlayton@redhat.com> <1206822608-20154-2-git-send-email-jlayton@redhat.com> <47FD0447.9030704@RedHat.com> <20080409141323.0c594185@barsoom.rdu.redhat.com> <47FD15FB.6090208@RedHat.com> <20080409153021.3947925b@barsoom.rdu.redhat.com> <47FD22F1.4030704@RedHat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: Jeff Layton , linux-nfs@vger.kernel.org, nfsv4@linux-nfs.org To: Steve Dickson Return-path: Received: from mx1.redhat.com ([66.187.233.31]:34156 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752305AbYDIV3v (ORCPT ); Wed, 9 Apr 2008 17:29:51 -0400 In-Reply-To: <47FD22F1.4030704-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: Steve Dickson wrote: > Jeff Layton wrote: > >> Yes. But like I mentioned in the description, there is a potential >> corner case here. If someone does a foreground mount and >> explicitly sets retry=10000 then it will be reset to 2. It's not very >> likely, but is simple enough to prevent... >> > hmm.. I guess... but programing for every single brain dead > corner case can really make the code more complicated than > it need to be, which I think is the case here... I think I would > rather just added the three lines and live that corner case... Customers tend to be remarkably good at finding corner cases and then wondering why they don't work as advertised... ps