From: Steve Dickson Subject: Re: [PATCH 1/3] mount.nfs: fix retry option settings with binary mount options Date: Wed, 09 Apr 2008 18:44:10 -0400 Message-ID: <47FD46BA.7040206@RedHat.com> References: <1206822608-20154-1-git-send-email-jlayton@redhat.com> <1206822608-20154-2-git-send-email-jlayton@redhat.com> <47FD0447.9030704@RedHat.com> <20080409141323.0c594185@barsoom.rdu.redhat.com> <47FD15FB.6090208@RedHat.com> <20080409153021.3947925b@barsoom.rdu.redhat.com> <47FD22F1.4030704@RedHat.com> <47FD354B.9020103@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: Jeff Layton , linux-nfs@vger.kernel.org, nfsv4@linux-nfs.org To: Peter Staubach Return-path: Received: from mx1.redhat.com ([66.187.233.31]:53118 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753264AbYDIWu5 (ORCPT ); Wed, 9 Apr 2008 18:50:57 -0400 In-Reply-To: <47FD354B.9020103@redhat.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: Peter Staubach wrote: > Steve Dickson wrote: >> Jeff Layton wrote: >> >>> Yes. But like I mentioned in the description, there is a potential >>> corner case here. If someone does a foreground mount and >>> explicitly sets retry=10000 then it will be reset to 2. It's not very >>> likely, but is simple enough to prevent... >>> >> hmm.. I guess... but programing for every single brain dead >> corner case can really make the code more complicated than >> it need to be, which I think is the case here... I think I would >> rather just added the three lines and live that corner case... > > Customers tend to be remarkably good at finding corner cases and > then wondering why they don't work as advertised... True... but... this feature has been busted for a while now and nobody even noticed... plus why would someone want to wait a week for a mount to finish... it seems a bit unreasonable My point was programing for every possible corner case will make the code unnecessarily complicated in a very quick way. Something I'm just trying avoid.. steved.