From: Peter Staubach Subject: Re: [PATCH] NFS: Only warn on unrecognized mount options Date: Fri, 11 Apr 2008 16:07:40 -0400 Message-ID: <47FFC50C.7020505@redhat.com> References: <20080411200249.28007.12509.stgit@manray.1015granger.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: trond.myklebust@netapp.com, linux-nfs@vger.kernel.org To: Chuck Lever Return-path: Received: from mx1.redhat.com ([66.187.233.31]:50197 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758865AbYDKUII (ORCPT ); Fri, 11 Apr 2008 16:08:08 -0400 In-Reply-To: <20080411200249.28007.12509.stgit-meopP2rzCrTwdl/1UfZZQIVfYA8g3rJ/@public.gmane.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: Chuck Lever wrote: > To provide compatibility with automounters who use a common set of mount > options for all file systems, change the NFS in-kernel mount option parser > to ignore mount options it doesn't recognize. > > Signed-off-by: Chuck Lever > --- > Yet another NFS mount patch! Build tested only. Comments? > > fs/nfs/super.c | 7 ++----- > 1 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/fs/nfs/super.c b/fs/nfs/super.c > index f921902..a7201f0 100644 > --- a/fs/nfs/super.c > +++ b/fs/nfs/super.c > @@ -1044,7 +1044,8 @@ static int nfs_parse_mount_options(char *raw, > break; > > default: > - goto out_unknown; > + printk(KERN_INFO "NFS: unrecognized mount option '%s'" > + " ignored\n", p); > } > } > > @@ -1070,10 +1071,6 @@ out_unrec_xprt: > out_unrec_sec: > printk(KERN_INFO "NFS: unrecognized security flavor\n"); > return 0; > - > -out_unknown: > - printk(KERN_INFO "NFS: unknown mount option: %s\n", p); > - return 0; > } > > /* This will potentially cause a very large number of messages to be printed in a valid deployment. Do we really need the message? ps