From: Trond Myklebust Subject: Re: [PATCH 6/8] SUNRPC: Add second output line for each RPC task in rpc_show_tasks Date: Mon, 19 May 2008 12:44:03 -0400 Message-ID: <1211215443.16052.10.camel@localhost> References: <20080518021241.8366.12464.stgit@ellison.1015granger.net> <20080518021650.8366.96474.stgit@ellison.1015granger.net> <1211214702.16052.7.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain Cc: linux-nfs@vger.kernel.org To: Chuck Lever Return-path: Received: from mx2.netapp.com ([216.240.18.37]:47843 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754978AbYESQoN (ORCPT ); Mon, 19 May 2008 12:44:13 -0400 In-Reply-To: Sender: linux-nfs-owner@vger.kernel.org List-ID: On Mon, 2008-05-19 at 12:41 -0400, Chuck Lever wrote: > On May 19, 2008, at 12:31 PM, Trond Myklebust wrote: > > On Sat, 2008-05-17 at 22:16 -0400, Chuck Lever wrote: > >> Add a second output line displayed for each RPC task shown via > >> rpc_show_tasks. This second line is for non-columnar variable-length > >> data (like the name of the RPC wait queue the task is waiting on, or > >> the procedure name). > > > > I don't really agree with this: it makes the output harder to parse > > rather than easier. grep, awk and friends don't cope well with > > multi-line data... > > Would it be better to put it all on one line, but the variable length > items are at the end and don't get a column header? That would make it easier, but why the change in format in the first place? This is developer-level debugging info: it is not designed for user comfort. -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@netapp.com www.netapp.com