From: "J. Bruce Fields" Subject: stuff Date: Fri, 9 May 2008 15:23:19 -0400 Message-ID: <20080509192319.GG1907@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Aurelien Charbon , Neil Brown , Brian Haley , YOSHIFUJI Hideaki / =?utf-8?B?5ZCJ6Jek6Iux5piO?= To: linux-nfs@vger.kernel.org Return-path: Received: from mail.fieldses.org ([66.93.2.214]:58969 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754736AbYEITXW (ORCPT ); Fri, 9 May 2008 15:23:22 -0400 Sender: linux-nfs-owner@vger.kernel.org List-ID: =46rom: J. Bruce Fields Commit f15364bd4cf8799a7677b6daeed7b67d9139d974 ("IPv6 support for NFS server export caches") dropped a couple spaces, rendering the output here difficult to read. (However note that we expect the output to be parsed only by humans, no= t machines, so this shouldn't have broken any userland software.) Signed-off-by: J. Bruce Fields Cc: Aurelien Charbon Cc: Neil Brown Cc: Brian Haley Cc: YOSHIFUJI Hideaki / =E5=90=89=E8=97=A4=E8=8B=B1=E6=98=8E --- net/sunrpc/svcauth_unix.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) I just noticed this while doing some debugging at Connectathon. I'm undecided whether to take it seriously. Does anyone other than me use these /content files? I suppose it should probably go into 2.6.26 but not 2.6.25.x. --b. diff --git a/net/sunrpc/svcauth_unix.c b/net/sunrpc/svcauth_unix.c index 3f30ee6..f24800f 100644 --- a/net/sunrpc/svcauth_unix.c +++ b/net/sunrpc/svcauth_unix.c @@ -278,7 +278,7 @@ static int ip_map_show(struct seq_file *m, dom =3D im->m_client->h.name; =20 if (ipv6_addr_v4mapped(&addr)) { - seq_printf(m, "%s" NIPQUAD_FMT "%s\n", + seq_printf(m, "%s " NIPQUAD_FMT " %s\n", im->m_class, ntohl(addr.s6_addr32[3]) >> 24 & 0xff, ntohl(addr.s6_addr32[3]) >> 16 & 0xff, @@ -286,7 +286,7 @@ static int ip_map_show(struct seq_file *m, ntohl(addr.s6_addr32[3]) >> 0 & 0xff, dom); } else { - seq_printf(m, "%s" NIP6_FMT "%s\n", + seq_printf(m, "%s " NIP6_FMT " %s\n", im->m_class, NIP6(addr), dom); } return 0; --=20 1.5.5.rc1