From: Trond Myklebust Subject: Re: [PATCH 2/5] rpc: Use separate spinlock for cred locking in auth_gss.c Date: Sat, 14 Jun 2008 11:58:55 -0400 Message-ID: <1213459135.7149.7.camel@localhost> References: <1213397442-15611-1-git-send-email-bfields@citi.umich.edu> <1213397442-15611-2-git-send-email-bfields@citi.umich.edu> <1213397442-15611-3-git-send-email-bfields@citi.umich.edu> Mime-Version: 1.0 Content-Type: text/plain Cc: aglo@citi.umich.edu, kwc@citi.umich.edu, linux-nfs@vger.kernel.org To: "J. Bruce Fields" Return-path: Received: from mx2.netapp.com ([216.240.18.37]:39267 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752948AbYFNP65 (ORCPT ); Sat, 14 Jun 2008 11:58:57 -0400 In-Reply-To: <1213397442-15611-3-git-send-email-bfields@citi.umich.edu> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Fri, 2008-06-13 at 18:50 -0400, J. Bruce Fields wrote: > The i_lock uses in auth_gss.c are to protect the gc_upcall and gc_ctx > fields of the gss cred; so we can use a separate per-auth spinlock for > those instead of the i_lock. This simplifies the locking in the case > where we have two different pipes (one the current pipe, one the pipe > for a new more flexible upcall), either of which might be used for gss > upcalls. NACK. I deliberately ripped out the old struct gss_auth spinlock in order to allow multiple gss_auth per inode (I believe Kevin was asking for this). Trond -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@netapp.com www.netapp.com