From: Chuck Lever Subject: Re: [PATCH 6/6] nfs: Fix misparsing of nfsv4 fs_locations attribute Date: Tue, 10 Jun 2008 11:34:14 -0400 Message-ID: References: <1213044696-32741-1-git-send-email-bfields@citi.umich.edu> <1213044696-32741-2-git-send-email-bfields@citi.umich.edu> <1213044696-32741-3-git-send-email-bfields@citi.umich.edu> <1213044696-32741-4-git-send-email-bfields@citi.umich.edu> <1213044696-32741-5-git-send-email-bfields@citi.umich.edu> <1213044696-32741-6-git-send-email-bfields@citi.umich.edu> <1213044696-32741-7-git-send-email-bfields@citi.umich.edu> <1213045696.19130.7.camel@localhost> <20080609212205.GB32446@fieldses.org> Mime-Version: 1.0 (Apple Message framework v924) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Cc: Trond Myklebust , linux-nfs@vger.kernel.org To: "J. Bruce Fields" Return-path: Received: from agminet01.oracle.com ([141.146.126.228]:35500 "EHLO agminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751839AbYFJPeq (ORCPT ); Tue, 10 Jun 2008 11:34:46 -0400 In-Reply-To: <20080609212205.GB32446@fieldses.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Jun 9, 2008, at 5:22 PM, J. Bruce Fields wrote: > On Mon, Jun 09, 2008 at 05:08:16PM -0400, Trond Myklebust wrote: >> >> What if it is an IPv6 address? As I've said before, could we please >> just >> adapt nfs_parse_server_address to deal with all these cases? > > I haven't had the time to do that, so I thought we'd rather have a fix > for the immediate bug now, then add ipv6 support later. For all I > know > the final patches might end up factoring reasonable cleanly that way > anyway. I have a patch (upcoming for 2.6.27) that fixes nfs_parse_server_address to be careful about '\0'-termination. It changes the function to take a char * and a length. All you will need to do is make it non-static. (I would have mentioned it yesterday but I thought I had dropped the patch from my "for 2.6.27" series). -- Chuck Lever chuck[dot]lever[at]oracle[dot]com