From: "J. Bruce Fields" <bfields@fieldses.org>
Subject: Re: [2.6 patch] uninline nfsd4_op_name()
Date: Sun, 10 Aug 2008 23:03:39 -0400
Message-ID: <20080811030339.GA5621@fieldses.org>
References: <20080808162642.GG14495@cs181140183.pp.htv.fi> <alpine.LFD.1.10.0808081120570.3462@nehalem.linux-foundation.org> <489ED1CF.8000308@panasas.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Adrian Bunk <bunk@kernel.org>, neilb@suse.de,
	linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
To: Benny Halevy <bhalevy@panasas.com>
Return-path: <linux-nfs-owner@vger.kernel.org>
Received: from mail.fieldses.org ([66.93.2.214]:47747 "EHLO fieldses.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754615AbYHKDDv (ORCPT <rfc822;linux-nfs@vger.kernel.org>);
	Sun, 10 Aug 2008 23:03:51 -0400
In-Reply-To: <489ED1CF.8000308@panasas.com>
Sender: linux-nfs-owner@vger.kernel.org
List-ID: <linux-nfs.vger.kernel.org>

On Sun, Aug 10, 2008 at 02:32:31PM +0300, Benny Halevy wrote:
> Linus Torvalds wrote:
> > 
> > On Fri, 8 Aug 2008, Adrian Bunk wrote:
> >> There doesn't seem to be a compelling reason why nfsd4_op_name() is 
> >> marked as "inline":
> 
> Agreed.
> 
> > 
> > It should also return a "const char *", I think.
> > 
> > Since it does.
> 
> Right.

OK, I modified that to add "const" as Linus suggests, and applied to

	git://linux-nfs.org/~bfields/linux.git for-2.6.27

Thanks to everyone.

--b.