From: Chris Mason Subject: Re: [PATCH] writeback: reset inode dirty time when adding it back to empty s_dirty list Date: Wed, 25 Mar 2009 16:07:02 -0400 Message-ID: <1238011622.5676.3.camel@think.oraclecorp.com> References: <1237840233-11045-1-git-send-email-jlayton@redhat.com> <20090324135720.GA25314@localhost> <20090324102806.4f38fd26@tleilax.poochiereds.net> <20090324104657.6907b19e@tleilax.poochiereds.net> <20090325012829.GA7506@localhost> <20090324221528.2bb7c50b@tleilax.poochiereds.net> <20090325025037.GA17374@localhost> <20090325075110.028f0d1d@tleilax.poochiereds.net> <20090325121742.GA22869@localhost> <20090325165500.GA6047@infradead.org> Mime-Version: 1.0 Content-Type: text/plain Cc: Wu Fengguang , Jeff Layton , Ian Kent , Dave Chinner , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "jens.axboe@oracle.com" , "akpm@linux-foundation.org" , "linux-nfs@vger.kernel.org" To: "hch@infradead.org" Return-path: Received: from rcsinet12.oracle.com ([148.87.113.124]:60523 "EHLO rgminet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751133AbZCYUJB (ORCPT ); Wed, 25 Mar 2009 16:09:01 -0400 In-Reply-To: <20090325165500.GA6047@infradead.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Wed, 2009-03-25 at 12:55 -0400, hch@infradead.org wrote: > On Wed, Mar 25, 2009 at 08:17:43PM +0800, Wu Fengguang wrote: > > Now there are now two possible solutions: > > - unconditionally update dirtied_when in redirty_tail(); > > - keep dirtied_when and redirty inodes to a new dedicated queue. > > The first one involves less code, the second one allows more flexible timing. > > > > NFS/XFS could be a good starting point for discussing the > > requirements, so that we can reach a suitable solution. > > Note that the XFS requirement also applies to all filesystems that > perform some sort of metadata updats on I/O completeion. That includes > at least ext4, btrfs and most likely the cluster filesystems too. btrfs at least doesn't dirty the inode on I/O completion. It just puts the changes directly into the btree blocks. -chris