From: "J. Bruce Fields" Subject: [PATCH] NFSD: provide encode routine for OP_OPENATTR Date: Wed, 18 Mar 2009 12:21:31 -0400 Message-ID: <1237393292-14934-2-git-send-email-bfields@fieldses.org> References: <1237393292-14934-1-git-send-email-bfields@fieldses.org> Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Igor Zhbanov , Serge Hallyn , Benny Halevy , stable@kernel.org, "J. Bruce Fields" To: Linus Torvalds Return-path: Received: from mail.fieldses.org ([141.211.133.115]:49035 "EHLO pickle.fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752614AbZCRQVj (ORCPT ); Wed, 18 Mar 2009 12:21:39 -0400 In-Reply-To: <1237393292-14934-1-git-send-email-bfields@fieldses.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: From: Benny Halevy Although this operation is unsupported by our implementation we still need to provide an encode routine for it to merely encode its (error) status back in the compound reply. Thanks for Bill Baker at sun.com for testing with the Sun OpenSolaris' client, finding, and reporting this bug at Connectathon 2009. This bug was introduced in 2.6.27 Signed-off-by: Benny Halevy Cc: stable@kernel.org Signed-off-by: J. Bruce Fields --- fs/nfsd/nfs4xdr.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c index f65953b..9250067 100644 --- a/fs/nfsd/nfs4xdr.c +++ b/fs/nfsd/nfs4xdr.c @@ -2596,6 +2596,7 @@ static nfsd4_enc nfsd4_enc_ops[] = { [OP_LOOKUPP] = (nfsd4_enc)nfsd4_encode_noop, [OP_NVERIFY] = (nfsd4_enc)nfsd4_encode_noop, [OP_OPEN] = (nfsd4_enc)nfsd4_encode_open, + [OP_OPENATTR] = (nfsd4_enc)nfsd4_encode_noop, [OP_OPEN_CONFIRM] = (nfsd4_enc)nfsd4_encode_open_confirm, [OP_OPEN_DOWNGRADE] = (nfsd4_enc)nfsd4_encode_open_downgrade, [OP_PUTFH] = (nfsd4_enc)nfsd4_encode_noop, -- 1.6.0.4