From: "J. Bruce Fields" Subject: Re: [PATCH 13/29] nfsd41: free drc cache buffers Date: Thu, 23 Apr 2009 19:39:44 -0400 Message-ID: <20090423233944.GN1906@fieldses.org> References: <1240504988-9572-5-git-send-email-andros@netapp.com> <1240504988-9572-6-git-send-email-andros@netapp.com> <1240504988-9572-7-git-send-email-andros@netapp.com> <1240504988-9572-8-git-send-email-andros@netapp.com> <1240504988-9572-9-git-send-email-andros@netapp.com> <1240504988-9572-10-git-send-email-andros@netapp.com> <1240504988-9572-11-git-send-email-andros@netapp.com> <1240504988-9572-12-git-send-email-andros@netapp.com> <1240504988-9572-13-git-send-email-andros@netapp.com> <1240504988-9572-14-git-send-email-andros@netapp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-nfs@vger.kernel.org, pnfs@linux-nfs.org To: andros@netapp.com Return-path: Received: from mail.fieldses.org ([141.211.133.115]:51553 "EHLO pickle.fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754156AbZDWXjp (ORCPT ); Thu, 23 Apr 2009 19:39:45 -0400 In-Reply-To: <1240504988-9572-14-git-send-email-andros@netapp.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Thu, Apr 23, 2009 at 12:42:52PM -0400, andros@netapp.com wrote: > From: Andy Adamson This should probably be folded into the last patch. (For one reason: looks like applying everything up to the last patch would result in a kernel that leaked memory, since these things never got freed? The rule here is that applying patches 1...n of any patch series should never introduce any new problems.) --b. > > Signed-off-by: Andy Adamson > --- > fs/nfsd/nfs4state.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c > index 9e79e0c..787cffe 100644 > --- a/fs/nfsd/nfs4state.c > +++ b/fs/nfsd/nfs4state.c > @@ -590,7 +590,7 @@ free_session(struct kref *kref) > ses = container_of(kref, struct nfsd4_session, se_ref); > for (i = 0; i < ses->se_fchannel.maxreqs; i++) { > struct nfsd4_cache_entry *e = &ses->se_slots[i].sl_cache_entry; > - nfsd4_release_respages(e->ce_respages, e->ce_resused); > + kfree(e->ce_datav.iov_base); > } > kfree(ses); > } > -- > 1.5.4.3 >