From: Krishna Kumar2 Subject: Re: [PATCH 3/11] nfsd: CHANGE old function calls to new calls Date: Sun, 26 Apr 2009 16:46:50 +0530 Message-ID: References: <20090325133607.16437.33288.sendpatchset@localhost.localdomain> <20090325133707.16437.66360.sendpatchset@localhost.localdomain> <20090422200553.GH9541@fieldses.org> <20090423223909.GF1906@fieldses.org> <20090424162321.GB17365@fieldses.org> <20090424192506.GQ17365@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: Greg Banks , jlayton@redhat.com, Krishna Kumar , linux-nfs@vger.kernel.org To: "J. Bruce Fields" Return-path: Received: from e28smtp09.in.ibm.com ([59.145.155.9]:52639 "EHLO e28smtp09.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751159AbZDZLRQ (ORCPT ); Sun, 26 Apr 2009 07:17:16 -0400 Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by e28smtp09.in.ibm.com (8.13.1/8.13.1) with ESMTP id n3QAggla030354 for ; Sun, 26 Apr 2009 16:12:42 +0530 Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n3QBH9EP622658 for ; Sun, 26 Apr 2009 16:47:09 +0530 Received: from d28av01.in.ibm.com (loopback [127.0.0.1]) by d28av01.in.ibm.com (8.13.1/8.13.3) with ESMTP id n3QBH8Jq027738 for ; Sun, 26 Apr 2009 16:47:08 +0530 In-Reply-To: <20090424192506.GQ17365@fieldses.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: "J. Bruce Fields" wrote on 04/25/2009 12:55:06 AM: > Why not use the whole thing?: > > fh1->fh_size == fh2->fh_size > && memcmp(fh1->fh_base, fh2->fh_base, fh1->fh_size) == 0 OK - so I just add a knfsd_fh in the cache and compare fh's. That sounds good, let me test and see what is the result. thanks, - KK