From: Trond Myklebust Subject: Re: [PATCH RFC 02/10] nfsd41: sunrpc: Added rpc server-side backchannel handling Date: Mon, 24 Aug 2009 19:42:27 -0400 Message-ID: <1251157347.6325.364.camel@heimdal.trondhjem.org> References: <4A8C9992.2000505@panasas.com> <1250728463-28511-1-git-send-email-bhalevy@panasas.com> <20090824233419.GE8532@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain Cc: Benny Halevy , linux-nfs@vger.kernel.org, pnfs@linux-nfs.org, Rahul Iyer , Mike Sager , Marc Eshel , Ricardo Labiaga , Andy Adamson , Alexandros Batsakis , Trond Myklebust To: "J. Bruce Fields" Return-path: Received: from mx2.netapp.com ([216.240.18.37]:56672 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753825AbZHXXm0 (ORCPT ); Mon, 24 Aug 2009 19:42:26 -0400 In-Reply-To: <20090824233419.GE8532@fieldses.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Mon, 2009-08-24 at 19:34 -0400, J. Bruce Fields wrote: > On Thu, Aug 20, 2009 at 03:34:23AM +0300, Benny Halevy wrote: > > From: Rahul Iyer > > > > Signed-off-by: Rahul Iyer > > Signed-off-by: Mike Sager > > Signed-off-by: Marc Eshel > > Signed-off-by: Benny Halevy > > Signed-off-by: Ricardo Labiaga > > This patch needs an ACK from Trond. > > > > > When the call direction is a reply, copy the xid and call direction into the > > req->rq_private_buf.head[0].iov_base otherwise rpc_verify_header returns > > rpc_garbage. > > Looks mostly OK, though blocking the client rpciod on the > bc_send_request method may be a problem--rpciod normally tries not to > sleep, and the other send_request methods look like they avoid it. Agreed. Blocking on sending is unacceptable inside rpciod. Please either use non-blocking I/O, or use a different thread context for this. -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@netapp.com www.netapp.com