From: andros@netapp.com Subject: [PATCH 1/2] nfsd41: fix NFSD_MIN_HDR_SEQ_SZ Date: Fri, 11 Sep 2009 18:52:54 -0400 Message-ID: <1252709575-3426-2-git-send-email-andros@netapp.com> References: <1252709575-3426-1-git-send-email-andros@netapp.com> Cc: pnfs@linux-nfs.org, linux-nfs@vger.kernel.org, Andy Adamson To: bfields@fieldses.org Return-path: Received: from mx2.netapp.com ([216.240.18.37]:19424 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753713AbZIKWxU (ORCPT ); Fri, 11 Sep 2009 18:53:20 -0400 In-Reply-To: <1252709575-3426-1-git-send-email-andros@netapp.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: From: Andy Adamson The reply RPC header is 12 bytes, the NULL verifier is 8 bytes giving 20 not 24 bytes in the NFSD_MIN_HDR_SEQ_SZ calculation, Signed-off-by: Andy Adamson --- fs/nfsd/nfs4state.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index 46e9ac5..5ecb42c 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c @@ -420,12 +420,12 @@ gen_sessionid(struct nfsd4_session *ses) * each time. Therefore we can advertise a ca_maxresponssize_cached * value that is the number of bytes in our cache plus a few additional * bytes. In order to stay on the safe side, and not promise more than - * we can cache, those additional bytes must be the minimum possible: 24 + * we can cache, those additional bytes must be the minimum possible: 20 * bytes of rpc header (xid through accept state, with AUTH_NULL * verifier), 12 for the compound header (with zero-length tag), and 44 * for the SEQUENCE op response: */ -#define NFSD_MIN_HDR_SEQ_SZ (24 + 12 + 44) +#define NFSD_MIN_HDR_SEQ_SZ (20 + 12 + 44) /* * Give the client the number of ca_maxresponsesize_cached slots it -- 1.6.2.5