From: Chuck Lever Subject: Re: [PATCH] NFS: Change default behavior when "sec=" is not specified by user Date: Tue, 1 Sep 2009 14:07:40 -0400 Message-ID: References: <20090901143012.3978.11441.stgit@matisse.1015granger.net> <20090901150545.GA22846@fieldses.org> <7C5C14D9-F315-4DF8-A2F4-C7F0981AC968@oracle.com> <20090901151830.GC22846@fieldses.org> <18678BB3-52C6-4376-BBD1-50B8947BAAC7@oracle.com> <20090901160914.GG22846@fieldses.org> <73E8EAAF-9164-4F78-A9D4-1CC86A6A6255@oracle.com> <20090901163846.GJ22846@fieldses.org> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Cc: trond.myklebust@fys.uio.no, linux-nfs@vger.kernel.org To: "J. Bruce Fields" Return-path: Received: from acsinet11.oracle.com ([141.146.126.233]:40406 "EHLO acsinet11.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751395AbZIASIB (ORCPT ); Tue, 1 Sep 2009 14:08:01 -0400 In-Reply-To: <20090901163846.GJ22846@fieldses.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Sep 1, 2009, at 12:38 PM, J. Bruce Fields wrote: > On Tue, Sep 01, 2009 at 12:29:30PM -0400, Chuck Lever wrote: >> On Sep 1, 2009, at 12:09 PM, J. Bruce Fields wrote: >>> And, sure, that'd be OK with me, and would probably be better than >>> adding another exception, so I'm OK with skipping #3. (We >>> definitely >>> shouldn't omit #2, though.) >> >> Seems straightforward enough, but... Why are we doing this again? >> It >> still seems like non-standard behavior. Are we simply attempting to >> avoid the case where folks would get the "nobody" behavior >> unexpectedly >> because of a mountd bug, or is there more to it? > > That's all there is to it. As I said: > >>>>>>> 2. In the absence of sec=, we should probably *not* choose >>>>>>> AUTH_NULL. (All mountd's before 1.1.3 list AUTH_NULL first on >>>>>>> the returned list, so users with older servers may wonder why a >>>>>>> client upgrade is making files they create suddenly be owned by >>>>>>> nobody.) http://marc.info/?l=linux-nfs&m=125089022306281&w=2 > >> I'm just thinking of what the documenting comment might say, and >> perhaps >> some explanation added to nfs(5). > > "As a special case, to work around bugs in some older servers, the > client will never automatically negotiate auth_null; if auth_null is > desired, an explicit "sec=null" on the commandline is required." > > Or something like that. OK, one more corner case. What if the mount doesn't specify "sec=" and the only flavor in the server's auth list is AUTH_NULL? Seems like we should allow that one. -- Chuck Lever chuck[dot]lever[at]oracle[dot]com