From: "J. Bruce Fields" Subject: Re: [PATCH 2/5] nfsd: Fix independence of a few nfsd related headers Date: Wed, 11 Nov 2009 12:36:39 -0500 Message-ID: <20091111173638.GC3128@fieldses.org> References: <4ADEC1EF.8040107@panasas.com> <1256112873-32495-1-git-send-email-bharrosh@panasas.com> <1256171298.6809.1.camel@heimdal.trondhjem.org> <4AE01569.9000002@panasas.com> <1256220146.6402.23.camel@heimdal.trondhjem.org> <4AE08165.2040100@panasas.com> <20091104220927.GS11637@fieldses.org> <4AFAD0EA.2080909@panasas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Trond Myklebust , Benny Halevy , pNFS Mailing List , NFS list , Andy Adamson To: Boaz Harrosh Return-path: Received: from fieldses.org ([174.143.236.118]:58590 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751931AbZKKRgW (ORCPT ); Wed, 11 Nov 2009 12:36:22 -0500 In-Reply-To: <4AFAD0EA.2080909@panasas.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Wed, Nov 11, 2009 at 04:57:46PM +0200, Boaz Harrosh wrote: > On 11/05/2009 12:09 AM, J. Bruce Fields wrote: > > On Thu, Oct 22, 2009 at 05:59:33PM +0200, Boaz Harrosh wrote: > > > > I'm assuming Trond's objection is just to the patch changelog > > (specifically, to the statement that any header "should be compilation > > independent"), not to these specific changes. > > > > --b. > > Ping > > Bruce? Trond? whatsup? > > Can Benny put these patches in his tree? He said he would be happy to hold > them for a while, but only if they will be eventually accepted into the > tree as a pnfs pre-requisite. Please ACK on these patches? > > I have to make all these put-the-includes-back patches to just make the tree > compile. They're fine by me. (Can't speak for Trond, but maybe his initial objection would be met just editing the changelog to replace the absolute "Any header should be compilation independent" by the particular advantages you saw in this case.) --b. > > Boaz >