From: Chuck Lever Subject: Re: [PATCH 2/2] NFS: Don't generate a GETATTR when opening an O_DIRECT file Date: Thu, 11 Feb 2010 14:20:18 -0500 Message-ID: <4B745872.7020807@oracle.com> References: <20100211185757.2666.90001.stgit@localhost.localdomain> <20100211190918.2666.82008.stgit@localhost.localdomain> <1265915652.478.22.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Cc: linux-nfs@vger.kernel.org To: Trond Myklebust Return-path: Received: from rcsinet11.oracle.com ([148.87.113.123]:24201 "EHLO rcsinet11.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756853Ab0BKTVQ (ORCPT ); Thu, 11 Feb 2010 14:21:16 -0500 In-Reply-To: <1265915652.478.22.camel@localhost> Sender: linux-nfs-owner@vger.kernel.org List-ID: On 02/11/2010 02:14 PM, Trond Myklebust wrote: > On Thu, 2010-02-11 at 14:09 -0500, Chuck Lever wrote: >> Close-to-open isn't needed for O_DIRECT files, since their data is >> never cached. So if their attribute cache hasn't expired, skip the >> GETATTR. > > Don't we still want to ensure that the access cache is still valid? Would it be reasonable/feasible to squelch the GETATTR but force an ACCESS call from nfs_permission? -- chuck[dot]lever[at]oracle[dot]com