Return-Path: Received: from fieldses.org ([174.143.236.118]:34027 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755509Ab0DEPqa (ORCPT ); Mon, 5 Apr 2010 11:46:30 -0400 Date: Mon, 5 Apr 2010 11:48:50 -0400 From: "J. Bruce Fields" To: Chuck Lever Cc: Tom Tucker , Steve Wise , "linux-nfs@vger.kernel.org" , linux-rdma@vger.kernel.org Subject: Re: [PATCH] svcrdma: RDMA support not yet compatible with RPC6 Message-ID: <20100405154850.GG16370@fieldses.org> References: <4BB74241.4060308@ogc.us> <4BB9F9D0.1040203@oracle.com> Content-Type: text/plain; charset=us-ascii In-Reply-To: <4BB9F9D0.1040203@oracle.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On Mon, Apr 05, 2010 at 10:55:12AM -0400, Chuck Lever wrote: > On 04/03/2010 09:27 AM, Tom Tucker wrote: >> RPC6 requires that it be possible to create endpoints that listen >> exclusively for IPv4 or IPv6 connection requests. This is not currently >> supported by the RDMA API. >> >> Signed-off-by: Tom Tucker >> Tested-by: Steve Wise > > Reviewed-by: Chuck Lever Thanks to all. I take it the problem began with 37498292a "NFSD: Create PF_INET6 listener in write_ports"? --b. > >> --- >> >> net/sunrpc/xprtrdma/svc_rdma_transport.c | 5 ++++- >> 1 files changed, 4 insertions(+), 1 deletions(-) >> >> diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c >> b/net/sunrpc/xprtrdma/svc_rdma_transport.c >> index 3fa5751..4e6bbf9 100644 >> --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c >> +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c >> @@ -678,7 +678,10 @@ static struct svc_xprt *svc_rdma_create(struct >> svc_serv *serv, >> int ret; >> >> dprintk("svcrdma: Creating RDMA socket\n"); >> - >> + if (sa->sa_family != AF_INET) { >> + dprintk("svcrdma: Address family %d is not supported.\n", sa->sa_family); >> + return ERR_PTR(-EAFNOSUPPORT); >> + } >> cma_xprt = rdma_create_xprt(serv, 1); >> if (!cma_xprt) >> return ERR_PTR(-ENOMEM); >> > > > -- > chuck[dot]lever[at]oracle[dot]com