Return-Path: Received: from fieldses.org ([174.143.236.118]:57561 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754478Ab0E1RPW (ORCPT ); Fri, 28 May 2010 13:15:22 -0400 From: "J. Bruce Fields" To: Benny Halevy Cc: linux-nfs@vger.kernel.org, Eric Anderle , "J. Bruce Fields" Subject: [PATCH 2/2] pnfsd: fix test in nfsd4_find_pnfs_dlm_device Date: Fri, 28 May 2010 13:15:21 -0400 Message-Id: <1275066921-29335-2-git-send-email-bfields@citi.umich.edu> In-Reply-To: <1275066921-29335-1-git-send-email-bfields@citi.umich.edu> References: <1275066921-29335-1-git-send-email-bfields@citi.umich.edu> Sender: linux-nfs-owner@vger.kernel.org List-ID: Content-Type: text/plain MIME-Version: 1.0 From: Eric Anderle This test is obviously backwards. Noticed because pnfs_dlm_device was allowing us to re-add the same disk multiple times. Signed-off-by: J. Bruce Fields --- fs/nfsd/nfs4pnfsdlm.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/nfsd/nfs4pnfsdlm.c b/fs/nfsd/nfs4pnfsdlm.c index 0351d71..1cf1b69 100644 --- a/fs/nfsd/nfs4pnfsdlm.c +++ b/fs/nfsd/nfs4pnfsdlm.c @@ -53,7 +53,7 @@ nfsd4_find_pnfs_dlm_device(char *disk_name) spin_lock(&dlm_device_list_lock); list_for_each_entry(dlm_pdev, &dlm_device_list, dlm_dev_list) { - if (memcmp(dlm_pdev->disk_name, disk_name, strlen(disk_name))) { + if (!memcmp(dlm_pdev->disk_name, disk_name, strlen(disk_name))) { spin_unlock(&dlm_device_list_lock); return dlm_pdev; } -- 1.7.0.4