From: Tao Guo Subject: Re: [PATCH v3] SQUASHME: pnfs: unlock lo_lock before calling layoutdriver's setup_layoutcommit Date: Wed, 26 May 2010 09:15:21 +0800 Message-ID: References: <20100525085119.GA7998@vmware> <4BFBD1C0.1040105@panasas.com> <4BFBE146.1060906@panasas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Boaz Harrosh , linux-nfs@vger.kernel.org To: Benny Halevy Return-path: Received: from mail-vw0-f46.google.com ([209.85.212.46]:52094 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759142Ab0EZBPW (ORCPT ); Tue, 25 May 2010 21:15:22 -0400 Received: by vws9 with SMTP id 9so3899621vws.19 for ; Tue, 25 May 2010 18:15:21 -0700 (PDT) In-Reply-To: Sender: linux-nfs-owner@vger.kernel.org List-ID: On Tue, May 25, 2010 at 11:26 PM, Tao Guo wrote: > On Tue, May 25, 2010 at 10:40 PM, Benny Halevy wrote: >> Boaz Harrosh wrote: >>> From: Tao Guo >>> >>> So in blocklayoutdriver, we can use GFP_KERNEL to do memory >>> allocation in bl_setup_layoutcommit(). >>> >>> The state protected by the lo_lock here is clear now, which is the >>> layout_commit's position and state. .i.e write_begin/end_pos, >>> nfsi->lo_cred, and the call to pnfs_get_layout_stateid. >> >> Yeah, this looks cleaner. > Yes, thanks. >> Tao, can you please test and ack this patch before I merge it? >> >> Thanks! >> >> Benny I have tested it, it is OK. Tao >