Return-Path: Received: from smtp.nokia.com ([192.100.105.134]:21853 "EHLO mgw-mx09.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753135Ab0GEMfa (ORCPT ); Mon, 5 Jul 2010 08:35:30 -0400 Subject: Re: [PATCH] sunrpc: make the cache cleaner workqueue deferrable From: Artem Bityutskiy Reply-To: dedekind1@gmail.com To: "J. Bruce Fields" Cc: Neil Brown , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Trond Myklebust , "David S. Miller" In-Reply-To: <1277996756-8415-1-git-send-email-dedekind1@gmail.com> References: <1277996756-8415-1-git-send-email-dedekind1@gmail.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 05 Jul 2010 15:31:30 +0300 Message-ID: <1278333090.29620.47.camel@localhost> Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On Thu, 2010-07-01 at 18:05 +0300, Artem Bityutskiy wrote: > From: Artem Bityutskiy > > This patch makes the cache_cleaner workqueue deferrable, to prevent > unnecessary system wake-ups, which is very important for embedded > battery-powered devices. > > do_cache_clean() is called every 30 seconds at the moment, and often > makes the system wake up from its power-save sleep state. With this > change, when the workqueue uses a deferrable timer, the > do_cache_clean() invocation will be delayed and combined with the > closest "real" wake-up. This improves the power consumption situation. > > Note, I tried to create a DECLARE_DELAYED_WORK_DEFERRABLE() helper > macro, similar to DECLARE_DELAYED_WORK(), but failed because of the > way the timer wheel core stores the deferrable flag (it is the > LSBit in the time->base pointer). My attempt to define a static > variable with this bit set ended up with the "initializer element is > not constant" error. > > Thus, I have to use run-time initialization, so I created a new > cache_initialize() function which is called once when sunrpc is > being initialized. > > Signed-off-by: Artem Bityutskiy Bruce, I did some git-logging, and found out that sunrpc stuff goes from you, from Trond, and from David, and MAINTAINERS also mentions Neil. Whom should I ping WRT to merging this patch? -- Best Regards, Artem Bityutskiy (Артём Битюцкий)