Date: Wed, 18 Aug 2010 14:54:56 -0400
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Neil Brown <neilb@suse.de>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
        "Patrick J. LoPresti" <lopresti@gmail.com>,
        linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Proposal: Use hi-res clock for file timestamps
Message-ID: <20100818185456.GD13050@fieldses.org>
References: <AANLkTimnyXKahtjaFeSsgcq=xMy-pP3na1jidQhZ-dt2@mail.gmail.com>
 <87aaolwar8.fsf@basil.nowhere.org>
 <20100817174134.GA23176@fieldses.org>
 <20100817182920.GD18161@basil.fritz.box>
 <20100817190447.GA28049@fieldses.org>
 <AANLkTi=w1UA5ZZDBigpxMiL7A7DnbnQhLkg62JZpC6Ri@mail.gmail.com>
 <20100817203941.729830b7@lxorguk.ukuu.org.uk>
 <20100817192937.GD26609@fieldses.org>
 <20100818155359.66b9ddb6@notabene>
 <20100818175040.GA6567@basil.fritz.box>
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <20100818175040.GA6567@basil.fritz.box>
Sender: linux-nfs-owner@vger.kernel.org
MIME-Version: 1.0

On Wed, Aug 18, 2010 at 07:50:40PM +0200, Andi Kleen wrote:
> >  - nfsd updates it whenever it reads an mtime out of an inode that matches
> >    current_fs_time to the granularity of 1/HZ.
> 
> That means you have a very very hot cache line on a larger system
> if there are a lot of mtime changes. Probably a bad idea.

Only if those mtime changes are also followed immediately by nfsd reads
of the mtime.

That will be the typical case for nfsd writes, though.

--b.