Return-Path: Received: from mx2.netapp.com ([216.240.18.37]:28845 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754901Ab0ITVhn convert rfc822-to-8bit (ORCPT ); Mon, 20 Sep 2010 17:37:43 -0400 Subject: Re: [PATCH 0/9] sunrpc: Start making sunrpc work in containers From: Trond Myklebust To: Chuck Lever Cc: "J. Bruce Fields" , Pavel Emelyanov , Neil Brown , linux-nfs@vger.kernel.org In-Reply-To: <14F506C2-8BDB-440E-A5A9-A99E4CC7512D@oracle.com> References: <4C90BADB.10700@parallels.com> <20100920161326.GL4580@fieldses.org> <4C978CE6.5080508@parallels.com> <20100920180418.GN4580@fieldses.org> <4C97B248.1030801@parallels.com> <20100920195635.GA18808@fieldses.org> <14F506C2-8BDB-440E-A5A9-A99E4CC7512D@oracle.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 20 Sep 2010 17:37:40 -0400 Message-ID: <1285018660.2851.162.camel@heimdal.trondhjem.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On Mon, 2010-09-20 at 16:35 -0400, Chuck Lever wrote: > On Sep 20, 2010, at 3:56 PM, J. Bruce Fields wrote: > > > On Mon, Sep 20, 2010 at 03:28:00PM -0400, Chuck Lever wrote: > >> > >> On Sep 20, 2010, at 3:13 PM, Pavel Emelyanov wrote: > >>> The nearest plan is > >>> > >>> 1. Prepare the sunrpc layer to work in net namespaces 2. Make > >>> rpcpipefs and nfsd filesystems be mountable multiple times 3. Make > >>> support for multiple instances of the nfsd caches 4. Make suuport > >>> for multiple instances of the nfsd_serv > >>> > >>> After this several NFSd-s can be used in containers (hopefully I > >>> didn't miss anything). > >> > >> Are you assuming NFSv4 only? Something needs to be done about NLM and > >> NSM to make this work right. > >> > >> Is there an issue for idmapper and svcgssd? Probably not, but worth > >> exploring. > >> > >> And, how about AUTH_SYS certs? These contain the host's name in them, > >> and that depends on the net namespace. NLM uses AUTH_SYS, and I > >> believe the NFS server can make NLM calls to the client. > > > > The client probably can't use the auth_sys cred on nlm callbacks in any > > sensible way, so this may not be a big deal. > > I doubt anything looks at that hostname, really. My worry is that it could leak information (like the wrong hostname) onto the network. > Which is one reason why using the utsname()->nodename at the time of mount is the correct thing to do. Trond