Subject: Re: [PATCH 5/5] NFS: clear fsinfo before sendign rpc
From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Benny Halevy <bhalevy@panasas.com>
Cc: Fred Isaman <iisaman@netapp.com>, linux-nfs@vger.kernel.org
In-Reply-To: <4CB617ED.4000504@panasas.com>
References: <4CA31DC3.8070300@panasas.com>
	 <1285758613-26897-1-git-send-email-bhalevy@panasas.com>
	 <AANLkTim8BCOgLNXZt3QKLX=g1dEruNEWHsb2GPs2AVYD@mail.gmail.com>
	 <4CB617ED.4000504@panasas.com>
Content-Type: text/plain; charset="UTF-8"
Date: Wed, 13 Oct 2010 16:54:39 -0400
Message-ID: <1287003279.3015.205.camel@heimdal.trondhjem.org>
Sender: linux-nfs-owner@vger.kernel.org
MIME-Version: 1.0

On Wed, 2010-10-13 at 16:34 -0400, Benny Halevy wrote:
> On 2010-10-13 14:03, Fred Isaman wrote:
> > On Wed, Sep 29, 2010 at 7:10 AM, Benny Halevy <bhalevy@panasas.com> wrote:
> >> To initialize all values to zero, in case the server or protocol version
> >> do no support particular attributes.
> > 
> > Sorry for the delayed response, but...
> > 
> > Zero is not an appropriate default for many of the values.  Further,
> > decode_fsinfo sets a default for each value, even in cases where the
> > server or protocol version do not support particular attributes.  So
> > this patch seems to server no purpose.
> 
> Note that nfs_probe_fsinfo is called also for nfs version 2 and 3
> and these don't know anything about nfsv4.1 attributes so they can't
> cannot explicitly set them to any default value.

Err... Why would we care? Under exactly what circumstances would we want
generic code to be processing fsinfo attributes that are specific only
to NFSv4.1?

Trond