Return-Path: Received: from smtp.nokia.com ([192.100.122.233]:56135 "EHLO mgw-mx06.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752495Ab0JMMvo (ORCPT ); Wed, 13 Oct 2010 08:51:44 -0400 From: Roman Borisov To: linux-kernel@vger.kernel.org Cc: Trond.Myklebust@netapp.com, linux-nfs@vger.kernel.org, Roman Borisov Subject: [PATCH] nfs: fix unchecked value Date: Wed, 13 Oct 2010 16:54:51 +0400 Message-Id: Sender: linux-nfs-owner@vger.kernel.org List-ID: Content-Type: text/plain MIME-Version: 1.0 Return value of "decode_attr_bitmap()" was not checked; Signed-off-by: Roman Borisov --- fs/nfs/nfs4xdr.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c index 6ea5c93..9e9cb40 100644 --- a/fs/nfs/nfs4xdr.c +++ b/fs/nfs/nfs4xdr.c @@ -2676,7 +2676,10 @@ out_overflow: static int decode_attr_supported(struct xdr_stream *xdr, uint32_t *bitmap, uint32_t *bitmask) { if (likely(bitmap[0] & FATTR4_WORD0_SUPPORTED_ATTRS)) { - decode_attr_bitmap(xdr, bitmask); + int ret; + ret = decode_attr_bitmap(xdr, bitmask); + if (unlikely(ret < 0)) + return ret; bitmap[0] &= ~FATTR4_WORD0_SUPPORTED_ATTRS; } else bitmask[0] = bitmask[1] = 0; -- 1.7.0.4