Return-Path: Received: from fieldses.org ([174.143.236.118]:48572 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933382Ab0J0PQt (ORCPT ); Wed, 27 Oct 2010 11:16:49 -0400 Date: Wed, 27 Oct 2010 11:16:46 -0400 From: "J. Bruce Fields" To: Christoph Hellwig Cc: Arnd Bergmann , Linus Torvalds , Bryan Schumaker , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: nfsd changes for 2.6.37 Message-ID: <20101027151645.GD6328@fieldses.org> References: <20101026164549.GD19445@fieldses.org> <20101027083924.GA28129@infradead.org> <20101027133924.GB6328@fieldses.org> <201010271546.09036.arnd@arndb.de> <20101027145538.GC6328@fieldses.org> <20101027145929.GA5788@infradead.org> Content-Type: text/plain; charset=us-ascii In-Reply-To: <20101027145929.GA5788@infradead.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On Wed, Oct 27, 2010 at 10:59:29AM -0400, Christoph Hellwig wrote: > On Wed, Oct 27, 2010 at 10:55:39AM -0400, J. Bruce Fields wrote: > > Hm, two problems: > > - We introduce the possibility of fcntl(fd, F_SETLEASE, F_UNLCK) > > failing with ENOMEM. > > splitt ->setlease into ->add_least and ->delete_lease. No need to pass > in a structure for the later. No need to return one either. Sounds fine to me. > > > - fasync_helper(.,.,1,.) sleeps. Argh. > > That's not new.. So we could do unlock_flocks(); error = fasync_helper(fd, filp, 1, &fl->fl_fasync); lock_flocks(); and say, hey, we didn't introduce any new bug there. But.... I don't know, maybe add a version of fasync_add_entry() that takes a preallocated fasync_struct?? --b.