Return-Path: Received: from netnation.com ([204.174.223.2]:38110 "EHLO peace.netnation.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751249Ab1ADVnf (ORCPT ); Tue, 4 Jan 2011 16:43:35 -0500 Date: Tue, 4 Jan 2011 13:43:34 -0800 From: Simon Kirby To: Trond Myklebust Cc: linux-nfs@vger.kernel.org Subject: Re: [PATCH 4/4] NFSv4: Send unmapped uid/gids to the server when using auth_sys Message-ID: <20110104214334.GI27727@hostway.ca> References: <1291085863-3234-1-git-send-email-Trond.Myklebust@netapp.com> <1291085863-3234-2-git-send-email-Trond.Myklebust@netapp.com> <1291085863-3234-3-git-send-email-Trond.Myklebust@netapp.com> <1291085863-3234-4-git-send-email-Trond.Myklebust@netapp.com> <1291085863-3234-5-git-send-email-Trond.Myklebust@netapp.com> <20110104212504.GG27727@hostway.ca> <1294176792.5896.22.camel@heimdal.trondhjem.org> Content-Type: text/plain; charset=us-ascii In-Reply-To: <1294176792.5896.22.camel@heimdal.trondhjem.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On Tue, Jan 04, 2011 at 04:33:12PM -0500, Trond Myklebust wrote: > On Tue, 2011-01-04 at 13:25 -0800, Simon Kirby wrote: > > I finally got around to setting up idmapd properly with libnss-mysql, and > > in doing so, I forgot that I had enabled nfs4_disable_idmapping=Y with > > this patch applied. With this option set on the client, and the server > > set up normally, I get EINVAL from chown's fchowna(): > > > > # chown testuser:testuser test > > chown: changing ownership of `test': Invalid argument > > # echo N > /sys/module/nfs/parameters/nfs4_disable_idmapping > > # chown testuser:testuser test > > # > > > > This happened on 2.6.37-rc5-git4, but I just reproduced it with > > 2.6.37-rc8-git5 as well. The server idmapd logs: > > > > rpc.idmapd[2987]: nss_getpwnam: name '1009999' does not map into domain 'localdomain' > > rpc.idmapd[2987]: Server: (user) name "1009999" -> id "65534" > > rpc.idmapd[2987]: nfsdcb: authbuf=10.10.52.0/24 authtype=group > > rpc.idmapd[2987]: Server: (group) name "1009999" -> id "65534" > > > > (1009999 is the current uid/gid here.) > > > > I think you meant for this to fall back automatically, right? > > Did you remember to apply the patch 'NFSv4: Propagate the error > NFS4ERR_BADOWNER to nfs4_do_setattr'? Yes, that patch is applied as part of the series. The -EINVAL is going back to userland's fchownat(). I expected to see the "Reenabling the idmapper" printk() from within nfs4_handle_exception(), but this didn't seem to happen. Simon-