Return-Path: Received: from daytona.panasas.com ([67.152.220.89]:19529 "EHLO daytona.panasas.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750783Ab1BMFW7 (ORCPT ); Sun, 13 Feb 2011 00:22:59 -0500 Message-ID: <4D576AB1.7030106@panasas.com> Date: Sun, 13 Feb 2011 07:22:57 +0200 From: Benny Halevy To: "J. Bruce Fields" CC: linux-nfs@vger.kernel.org Subject: Re: [bfields@pop.test.fieldses.org: all 4c5fcc5e SQUASHME: pnfs-obj: use pnfs_layout_hdr and layout_segment field prefix results] References: <20110211152941.GB3005@fieldses.org> In-Reply-To: <20110211152941.GB3005@fieldses.org> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On 2011-02-11 17:29, J. Bruce Fields wrote: > Is this something that only shows when pnfs is configured out, maybe? Doesn't show up with my .config, with or without pnfs configured... Does this help? diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c index f08ab55..35d2567 100644 --- a/fs/nfsd/nfs4proc.c +++ b/fs/nfsd/nfs4proc.c @@ -33,6 +33,7 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ #include +#include #include #include #include > > --b. > > ----- Forwarded message from "J. Bruce Fields" ----- > > Date: Fri, 11 Feb 2011 02:42:18 -0500 > From: "J. Bruce Fields" > To: bfields@fieldses.org > Subject: all 4c5fcc5e SQUASHME: pnfs-obj: use pnfs_layout_hdr and > layout_segment field prefix results > > 6210 all 4c5fcc5e SQUASHME: pnfs-obj: use pnfs_layout_hdr and layout_segment field prefix > fs/cifs/file.c: In function 'cifs_iovec_write': > fs/cifs/file.c:1740: warning: passing argument 6 of 'CIFSSMBWrite2' from incompatible pointer type > fs/cifs/cifsproto.h:343: note: expected 'unsigned int *' but argument is of type 'size_t *' > fs/cifs/link.c: In function 'symlink_hash': > fs/cifs/link.c:58: warning: 'rc' may be used uninitialized in this function > fs/cifs/smbencrypt.c: In function 'mdfour': > fs/cifs/smbencrypt.c:61: warning: 'rc' may be used uninitialized in this function > In file included from include/linux/nfsd/nfsd4_pnfs.h:39, > from include/linux/nfsd/nfs4layoutxdr.h:38, > from fs/nfsd/nfs4proc.c:37: > include/linux/nfs_xdr.h:1124: error: field 'refcount' has incomplete type > make[2]: *** [fs/nfsd/nfs4proc.o] Error 1 > make[1]: *** [fs/nfsd] Error 2 > make[1]: *** Waiting for unfinished jobs.... > make: *** [fs] Error 2 > make: *** Waiting for unfinished jobs.... > > started Fri Feb 11 02:22:03 EST 2011, finished Fri Feb 11 02:42:18 EST 2011 > > > +-----------------------------------------+ > | verbose output | > +-----------------------------------------+ > > ----- End forwarded message -----