Return-Path: Received: from rcsinet10.oracle.com ([148.87.113.121]:39597 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755791Ab1CNMrf convert rfc822-to-8bit (ORCPT ); Mon, 14 Mar 2011 08:47:35 -0400 Subject: Re: [PATCH] SUNRPC: svc_register error overwritten in next iteration Content-Type: text/plain; charset=us-ascii From: Chuck Lever In-Reply-To: <4D7B74C7.7060506@gmail.com> Date: Mon, 14 Mar 2011 08:47:18 -0400 Cc: "J. Bruce Fields" , Neil Brown , linux-nfs@vger.kernel.org, Andrew Morton , LKML Message-Id: References: <4D7B74C7.7060506@gmail.com> To: roel Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On Mar 12, 2011, at 8:27 AM, roel wrote: > The break is in the inner loop, the svc_register() error is overwritten > in the next iteration. Only the error in the last iteration is returned. > > Signed-off-by: Roel Kluin > --- > net/sunrpc/svc.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > Is this needed? Maybe. Did you encounter a problem here? > diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c > index 08e05a8..5fd08c0 100644 > --- a/net/sunrpc/svc.c > +++ b/net/sunrpc/svc.c > @@ -889,6 +889,8 @@ int svc_register(const struct svc_serv *serv, const int family, > if (error < 0) > break; > } > + if (error < 0) > + break; > } > > return error; -- Chuck Lever chuck[dot]lever[at]oracle[dot]com