Return-Path: Received: from cantor.suse.de ([195.135.220.2]:58367 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752199Ab1CPWk2 (ORCPT ); Wed, 16 Mar 2011 18:40:28 -0400 Date: Thu, 17 Mar 2011 09:40:19 +1100 From: NeilBrown To: Trond Myklebust Cc: Bryan Schumaker , Chuck Lever , Linux NFS Mailing List Subject: Re: Use of READDIRPLUS on large directories Message-ID: <20110317094019.23f31f53@notabene.brown> In-Reply-To: <1300311755.30551.17.camel@lade.trondhjem.org> References: <20110316155528.31913c58@notabene.brown> <24085EE6-EF0B-4F36-8F6A-100AB863F408@oracle.com> <4D80C5C6.2060003@netapp.com> <1300285203.16266.46.camel@lade.trondhjem.org> <20110317083034.479ecb5f@notabene.brown> <1300311755.30551.17.camel@lade.trondhjem.org> Content-Type: text/plain; charset=US-ASCII Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On Wed, 16 Mar 2011 17:42:35 -0400 Trond Myklebust wrote: > > So it is obvious that there is sometimes value in using readdirplus, > > it is equally obvious that there is sometimes a cost. > > > > Switching the default from "not paying the cost when it is big" to > > "always paying the cost" is wrong. > > That's what the nordirplus mount flag is for. Keeping an arbitrary limit > in the face of evidence that it is hurting is equally wrong. > If people didn't need 'nordirplus' previously to get acceptable performance, and do need it now, then that is a regression. NeilBrown