Return-Path: Received: from fieldses.org ([174.143.236.118]:43176 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750970Ab1DVTbH (ORCPT ); Fri, 22 Apr 2011 15:31:07 -0400 Date: Fri, 22 Apr 2011 15:31:03 -0400 From: "J. Bruce Fields" To: Adam Lackorzynski Cc: Christoph Hellwig , linux-nfs@vger.kernel.org, xfs@oss.sgi.com Subject: Re: 2.6.38: Quota over NFS4 Message-ID: <20110422193103.GB32290@fieldses.org> References: <20110321222301.GB472@fieldses.org> <20110322221305.GA5857@os.inf.tu-dresden.de> <20110323150328.GD23418@fieldses.org> <20110323174052.GE5005@os.inf.tu-dresden.de> <20110323190632.GA26306@fieldses.org> <20110323223017.GA5177@os.inf.tu-dresden.de> <20110324171704.GA1784@infradead.org> <20110324175106.GB1886@fieldses.org> <20110324222807.GC10821@os.inf.tu-dresden.de> <20110325000310.GA5514@fieldses.org> Content-Type: text/plain; charset=us-ascii In-Reply-To: <20110325000310.GA5514@fieldses.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On Thu, Mar 24, 2011 at 08:03:10PM -0400, J. Bruce Fields wrote: > On Thu, Mar 24, 2011 at 11:28:07PM +0100, Adam Lackorzynski wrote: > > > > On Thu Mar 24, 2011 at 13:51:06 -0400, J. Bruce Fields wrote: > > > On Thu, Mar 24, 2011 at 01:17:05PM -0400, Christoph Hellwig wrote: > > > > On Wed, Mar 23, 2011 at 11:30:17PM +0100, Adam Lackorzynski wrote: > > > > > I probably mistyped something and thus bisected again: > > > > > > > > maybe this is just a symptom. When was the nfs4 code converted > > > > to just use a single open struct file, and what are the lifetime > > > > rules for it? It would easily be that a long alive file might > > > > make XFS keep persistent preallocations longer or similar issues. > > > > > > Definitely, the commit he's bisect to there seems much more likely to be > > > a culprit. I'll take a closer look.... > > > > > > > Adam, can you create a loop filesystem with ext3 or something else > > > > on it and see if the problem is XFS-specific? > > > > > > Originally it sounded like he was able to reproduce this only on one > > > specific filesystem so I wondered whether there was something particular > > > to that filesystem. > > > > I just found out it happens also with a newly created xfs and also with > > ext3 and ext4. The reason that I did not see that initially is that the > > script I'm using needs to be on the same fs which wasn't the case when I > > initially tried it with a new fs. The sequence I'm using is: > > Ah-hah, got it. So the leak's probably of a delegation on the file > containing the script itself. OK, I should be able to fix that, thanks! This should be fixed in the latest upstream (so, in 39-rc5, when that comes out) and soon in stable. Let me know if not. --b.