Return-Path: Received: from daytona.panasas.com ([67.152.220.89]:47107 "EHLO daytona.panasas.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750803Ab1EWEic (ORCPT ); Mon, 23 May 2011 00:38:32 -0400 Message-ID: <4DD9E4B6.70200@panasas.com> Date: Mon, 23 May 2011 07:38:14 +0300 From: Boaz Harrosh To: Benny Halevy CC: Trond Myklebust , linux-nfs@vger.kernel.org Subject: Re: [PATCH v5 20/38] pnfs: per mount layout driver private data References: <4DD99F9B.2040406@panasas.com> <1306108649-28644-1-git-send-email-bhalevy@panasas.com> In-Reply-To: <1306108649-28644-1-git-send-email-bhalevy@panasas.com> Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On 05/23/2011 02:57 AM, Benny Halevy wrote: > With the objects layout security model we have object capabilities > that are associated with the layout ad we anticipate that the server > will issue a cb_layoutrecall for any setattr that changes security > related attributes (user/group/mode/acl) or truncates the file. > Therefore, the client returns the layout in advance to avoid the > extra layout recall. > This looks like the wrong text. It belongs to that other patch. The title and actual patch do match Boaz > [get rid of ds_[rw]size] > Signed-off-by: Benny Halevy > --- > include/linux/nfs_fs_sb.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/include/linux/nfs_fs_sb.h b/include/linux/nfs_fs_sb.h > index 87694ca..66e031f 100644 > --- a/include/linux/nfs_fs_sb.h > +++ b/include/linux/nfs_fs_sb.h > @@ -143,6 +143,7 @@ struct nfs_server { > filesystem */ > struct pnfs_layoutdriver_type *pnfs_curr_ld; /* Active layout driver */ > struct rpc_wait_queue roc_rpcwaitq; > + void *pnfs_ld_data; /* Per-mount data */ > > /* the following fields are protected by nfs_client->cl_lock */ > struct rb_root state_owners;