Return-Path: Received: from int-mailstore01.merit.edu ([207.75.116.232]:51734 "EHLO int-mailstore01.merit.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757391Ab1FGRdN (ORCPT ); Tue, 7 Jun 2011 13:33:13 -0400 Date: Tue, 7 Jun 2011 13:33:11 -0400 From: Jim Rees To: Benny Halevy Cc: linux-nfs@vger.kernel.org, peter honeyman Subject: [PATCH 60/88] SQUASHME: pnfs-block: nfs4_blk_add_block_disk ret must be signed Message-ID: References: Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 From: Benny Halevy otherwise checking for ret < 0 is futile. Signed-off-by: Benny Halevy --- fs/nfs/blocklayout/blocklayoutdev.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/nfs/blocklayout/blocklayoutdev.c b/fs/nfs/blocklayout/blocklayoutdev.c index ef39c36..a866f5c 100644 --- a/fs/nfs/blocklayout/blocklayoutdev.c +++ b/fs/nfs/blocklayout/blocklayoutdev.c @@ -105,7 +105,8 @@ nfs4_blk_add_block_disk(struct device *cdev, static char *claim_ptr = "I belong to pnfs block driver"; struct block_device *bdev; struct gendisk *gd; - unsigned int major, minor, ret = 0; + unsigned int major, minor; + int ret; dev_t dev; dprintk("%s enter \n", __func__); -- 1.7.4.1