Return-Path: Received: from fieldses.org ([174.143.236.118]:37272 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932217Ab1F2Tyt (ORCPT ); Wed, 29 Jun 2011 15:54:49 -0400 Date: Wed, 29 Jun 2011 15:54:47 -0400 From: "J. Bruce Fields" To: Bryan Schumaker Cc: linux-nfs@vger.kernel.org Subject: Re: [PATCH 2/2] NFSD: Added TEST_STATEID operation Message-ID: <20110629195447.GC3279@fieldses.org> References: <1305922380-8162-1-git-send-email-bjschuma@netapp.com> <1305922380-8162-3-git-send-email-bjschuma@netapp.com> <4E0B81B6.8060005@netapp.com> Content-Type: text/plain; charset=us-ascii In-Reply-To: <4E0B81B6.8060005@netapp.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On Wed, Jun 29, 2011 at 03:49:10PM -0400, Bryan Schumaker wrote: > On 05/20/2011 04:13 PM, bjschuma@netapp.com wrote: > > +__be32 > > +nfsd4_do_test_stateid(stateid_t *stateid, int flags) > > +{ > > + __be32 ret = nfs4_validate_stateid(stateid, flags); > > + if (!ret) > > + ret = nfs4_validate_stateid(stateid, flags); > > + return ret; > > Looking back at this, I'm not convinced that I need to call nfs4_validate_stateid() twice with the same stateid and flags. What is the status of these patches? Should I resubmit everything or send in a small patch to fix this? Whoops, lazy review on my part.... Looks like I'd applied that locally but not pushed it out to my public tree yet, so I could still take a replacement. How are you testing these, by the way? On second thoughts, I think I may have already asked you that, and forgotten the answer, so don't bother answering here--just add some text to the changelog and then I'll know how to find the answer next time. --b.