Return-Path: Received: from acsinet15.oracle.com ([141.146.126.227]:28658 "EHLO acsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751765Ab1G2Rk3 convert rfc822-to-8bit (ORCPT ); Fri, 29 Jul 2011 13:40:29 -0400 Subject: Re: [NLM] support for a per-mount grace period. Content-Type: text/plain; charset=us-ascii From: Chuck Lever In-Reply-To: <20110729171126.GN23194@fieldses.org> Date: Fri, 29 Jul 2011 13:40:07 -0400 Cc: Frank van Maarseveen , linux-nfs@vger.kernel.org, Pavel Emelyanov , jlayton@redhat.com Message-Id: <1B4AE155-0809-4CF4-9A53-80A318050D8F@oracle.com> References: <1311878660-24482-1-git-send-email-frankvm@frankvm.com> <20110729171126.GN23194@fieldses.org> To: "J. Bruce Fields" Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On Jul 29, 2011, at 1:11 PM, J. Bruce Fields wrote: > On Thu, Jul 28, 2011 at 08:44:18PM +0200, Frank van Maarseveen wrote: >> The following two patches implement support for a per-mount NLM >> grace period. The first patch is a minor cleanup which pushes >> down locks_in_grace() calls into functions shared by NFS[234]. Two >> locks_in_grace() tests have been reordered to avoid duplicate calls at >> run-time (assuming gcc is smart enough). nlmsvc_grace_period is now a >> function instead of an unused variable. >> >> The second patch is the actual implementation. It is currently in use for >> a number of NFSv3 virtual servers on one physical machine running 2.6.39.3 >> where the virtualization is based on using different IPv4 addresses. > > Thanks, that is something we'd like to have working well. > > Off the top of my head: > - Do you have a plan for dealing with NFSv4? > - Do you need any more kernel changes to get this working? > - What about userspace changes? > - Do you support migrating/failing over virtual nfs service > between machines, and if so, how are you doing it? Nit: At one point we had considered doing something like killing sm-notify when the grace period ends on the server. This would make that harder to do, I would think. > I've also been trying to work out whether it would be cleaner to do this > sort of thing by building on top of Pavel Emelyanov's container > work--cc'd. > > (Obnoxious of me, because I know he's working on something else right > now, but perhaps he won't mind setting this email aside for now and > responding when he gets some time back....) > > --b. > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Chuck Lever chuck[dot]lever[at]oracle[dot]com