Return-Path: Received: from natasha.panasas.com ([67.152.220.90]:50541 "EHLO natasha.panasas.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751838Ab1G0UUZ (ORCPT ); Wed, 27 Jul 2011 16:20:25 -0400 Message-ID: <4E3072F3.7090802@panasas.com> Date: Wed, 27 Jul 2011 13:20:03 -0700 From: Boaz Harrosh To: Trond Myklebust CC: Jim Rees , , peter honeyman Subject: Re: [PATCH v3 06/25] pnfs: cleanup_layoutcommit References: <1311792048-12551-1-git-send-email-rees@umich.edu> <1311792048-12551-7-git-send-email-rees@umich.edu> <1311796389.25645.20.camel@lade.trondhjem.org> In-Reply-To: <1311796389.25645.20.camel@lade.trondhjem.org> Content-Type: text/plain; charset="UTF-8" Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On 07/27/2011 12:53 PM, Trond Myklebust wrote: >> diff --git a/fs/nfs/pnfs.h b/fs/nfs/pnfs.h >> index bddd8b9..f271425 100644 >> --- a/fs/nfs/pnfs.h >> +++ b/fs/nfs/pnfs.h >> @@ -113,6 +113,9 @@ struct pnfs_layoutdriver_type { >> struct xdr_stream *xdr, >> const struct nfs4_layoutreturn_args *args); >> >> + void (*cleanup_layoutcommit) (struct pnfs_layout_hdr *layoutid, >> + struct nfs4_layoutcommit_data *data); >> + >> void (*encode_layoutcommit) (struct pnfs_layout_hdr *layoutid, >> struct xdr_stream *xdr, >> const struct nfs4_layoutcommit_args *args); > > This really needs to go. We should have > > int (*layoutcommit)()... > > instead of 'encode' and 'cleanup' methods... > Theoretically it is not possible because the blocks-layout protocol mandates different handling depending on the "error" response from the Server which will be received on RPC done. Though, Last I was diving into this code, The proper handling was missing. (It was a while back though things might have changed) Boaz