Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:10774 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751223Ab1G0A6C (ORCPT ); Tue, 26 Jul 2011 20:58:02 -0400 Subject: Re: [Libtirpc-devel] [PATCH] Autofs configure fails to detect IPv6 when libtirpc is enabled From: Ian Kent To: Steve Dickson Cc: Chuck Lever , autofs mailing list , Linux NFS Mailing List , Libtirpc Devel List In-Reply-To: <4E2F2DE6.5030500@RedHat.com> References: <1311683346-16881-1-git-send-email-steved@redhat.com> <8A84CF7D-9579-4645-AE5D-FE8358F466C0@gmail.com> <4E2F2DE6.5030500@RedHat.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 27 Jul 2011 08:57:11 +0800 Message-ID: <1311728231.3473.7.camel@perseus.themaw.net> Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On Tue, 2011-07-26 at 17:13 -0400, Steve Dickson wrote: > > On 07/26/2011 10:50 AM, Chuck Lever wrote: > > > > On Jul 26, 2011, at 2:29 PM, Steve Dickson wrote: > > > >> From: Ian Kent > >> > >> The IPv6 client functions clntudp6_bufcreate(), clntudp6_create and > >> clnttcp6_create and the server functions svcudp6_bufcreate(), > >> svctcp6_create() and svcudp6_create() are not included in the library > >> whe libtirpc is built. > > > > Are these part of the libtirpc standard API? I'm not sure why we would need them if, say, Solaris does not support these. > It appears they are not since they are not mentioned the man pages..... > But, at least in the autofs code, they are expected > https://bugzilla.redhat.com/show_bug.cgi?id=711956#c0 > > Ian, where else are these routines defined? Now that I look I can't find the original source tar that was used for libtirpc, thought I had it. The story is that long ago when I changed autofs to use libtirpc (to make it ready for IPv6) I found these functions in the source and they were (obviously) the IPv6 counterparts for the corresponding IPv4 functions which I was already using, so I used them. It took me quite a while to realize my code wasn't working and then I found that somewhere along the line they have been excluded, oops! If there are to be no IPv6 counterparts for the corresponding IPv4 functions which functions should I use then? > > steved > > > > >> Signed-off-by: Steve Dickson > >> --- > >> src/rpc_soc.c | 4 ++-- > >> 1 files changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/src/rpc_soc.c b/src/rpc_soc.c > >> index c678429..584ac71 100644 > >> --- a/src/rpc_soc.c > >> +++ b/src/rpc_soc.c > >> @@ -236,7 +236,7 @@ clnttcp_create(raddr, prog, vers, sockp, sendsz, recvsz) > >> > >> /* IPv6 version of clnt*_*create */ > >> > >> -#ifdef INET6_NOT_USED > >> +#ifdef INET6 > >> > >> CLIENT * > >> clntudp6_bufcreate(raddr, prog, vers, wait, sockp, sendsz, recvsz) > >> @@ -392,7 +392,7 @@ svcraw_create() > >> > >> > >> /* IPV6 version */ > >> -#ifdef INET6_NOT_USED > >> +#ifdef INET6 > >> SVCXPRT * > >> svcudp6_bufcreate(fd, sendsz, recvsz) > >> int fd; > >> -- > >> 1.7.6 > >> > >> > >> ------------------------------------------------------------------------------ > >> Magic Quadrant for Content-Aware Data Loss Prevention > >> Research study explores the data loss prevention market. Includes in-depth > >> analysis on the changes within the DLP market, and the criteria used to > >> evaluate the strengths and weaknesses of these DLP solutions. > >> http://www.accelacomm.com/jaw/sfnl/114/51385063/ > >> _______________________________________________ > >> Libtirpc-devel mailing list > >> Libtirpc-devel@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/libtirpc-devel > > > > ------------------------------------------------------------------------------ > Got Input? Slashdot Needs You. > Take our quick survey online. Come on, we don't ask for help often. > Plus, you'll get a chance to win $100 to spend on ThinkGeek. > http://p.sf.net/sfu/slashdot-survey > _______________________________________________ > Libtirpc-devel mailing list > Libtirpc-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/libtirpc-devel