Message-ID: <4E35A9B1.9090309@fusionio.com>
Date: Sun, 31 Jul 2011 21:14:57 +0200
From: Jens Axboe <jaxboe@fusionio.com>
To: Christoph Hellwig <hch@infradead.org>
CC: Trond Myklebust <Trond.Myklebust@netapp.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        <linux-fsdevel@vger.kernel.org>, <linux-nfs@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: Please pull NFS client changes
References: <1312082377.10882.1.camel@lade.trondhjem.org> <20110731182406.GA16470@infradead.org>
In-Reply-To: <20110731182406.GA16470@infradead.org>
Content-Type: text/plain; charset="windows-1252"
Sender: linux-nfs-owner@vger.kernel.org
MIME-Version: 1.0

On 2011-07-31 20:24, Christoph Hellwig wrote:
> How does this manage to include the pnfs block code, which only was posted
> on the list a few hours before the pull request, and which doesn't
> appear to past testing very well (although the major issue seems to be
> core nfs code)?

And it doesn't even compile:

In file included from fs/nfs/client.c:51:0:
fs/nfs/pnfs.h:384:1: error: expected identifier or ?(? before ?{? token
fs/nfs/client.c: In function ?nfs_server_set_fsinfo?:
fs/nfs/client.c:939:8: error: ?struct nfs_server? has no member named
?pnfs_blksize?
fs/nfs/client.c: At top level:
fs/nfs/pnfs.h:382:20: warning: ?set_pnfs_layoutdriver? used but never
defined [enabled by default]
make[2]: *** [fs/nfs/client.o] Error 1


-- 
Jens Axboe