Message-ID: <4E54B5C3.5040003@cn.fujitsu.com>
Date: Wed, 24 Aug 2011 16:26:43 +0800
From: Mi Jinlong <mijinlong@cn.fujitsu.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
CC: NFS <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 1/4 v3] 4.1 CLNT: add a simple test about RECLAIM_COMPLETE
References: <4E4C7679.7000108@cn.fujitsu.com> <4E4C76C6.8020901@cn.fujitsu.com> <20110823214346.GD25350@fieldses.org>
In-Reply-To: <20110823214346.GD25350@fieldses.org>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-nfs-owner@vger.kernel.org
MIME-Version: 1.0


J. Bruce Fields :
> On Thu, Aug 18, 2011 at 10:19:50AM +0800, Mi Jinlong wrote:
>> Signed-off-by: Mi Jinlong <mijinlong@cn.fujitsu.com>
> 
> Is it even possible to run this test without an earlier RECLAIM_COMPLETE
> failing?  I guess so, if you just run this one test without --maketree.

  NO, it's OK. As:

   ]# ./testserver.py --outfile=first.log 127.0.0.1:/ RECC1
     INFO   :rpc.poll:got connection from ('127.0.0.1', 52268), assigned to fd=5
     INFO   :rpc.thread:Called connect(('127.0.0.1', 2049))
     INFO   :rpc.poll:Adding 6 generated by another thread
     INFO   :test.env:Created client to 127.0.0.1, 2049
     INFO   :nfs.client.cb:********************
     INFO   :nfs.client.cb:Handling CB_NULL
     INFO   :test.env:Called do_readdir()
     INFO   :test.env:do_readdir() = []
     INFO   :nfs.client.cb:********************
     INFO   :nfs.client.cb:Handling CB_NULL
     **************************************************
     RECC1    st_reclaim_complete.testSupported                        : PASS
     **************************************************
     Command line asked for 1 of 165 tests
     Of those: 0 Skipped, 0 Failed, 0 Warned, 1 Passed

thanks,
Mi Jinlong

> 
>> ---
>>  nfs4.1/server41tests/__init__.py            |    1 +
>>  nfs4.1/server41tests/st_reclaim_complete.py |   21 +++++++++++++++++++++
>>  2 files changed, 22 insertions(+), 0 deletions(-)
>>  create mode 100644 nfs4.1/server41tests/st_reclaim_complete.py
>>
>> diff --git a/nfs4.1/server41tests/__init__.py b/nfs4.1/server41tests/__init__.py
>> index 3b4411a..1cc2048 100644
>> --- a/nfs4.1/server41tests/__init__.py
>> +++ b/nfs4.1/server41tests/__init__.py
>> @@ -2,6 +2,7 @@ __all__ = ["st_exchange_id.py", # draft 21
>>             "st_compound.py",
>>             "st_create_session.py",
>>             "st_destroy_session.py",
>> +           "st_reclaim_complete.py",
>>             "st_secinfo_no_name.py",
>>             "st_secinfo.py",
>>             "st_sequence.py",
>> diff --git a/nfs4.1/server41tests/st_reclaim_complete.py b/nfs4.1/server41tests/st_reclaim_complete.py
>> new file mode 100644
>> index 0000000..a591ef5
>> --- /dev/null
>> +++ b/nfs4.1/server41tests/st_reclaim_complete.py
>> @@ -0,0 +1,21 @@
>> +from st_create_session import create_session
>> +from nfs4_const import *
>> +from environment import check, fail
>> +import nfs4_ops as op
>> +import nfs4lib
>> +
>> +def testSupported(t, env):
>> +    """Do a simple RECLAIM_COMPLETE
>> +
>> +    FLAGS: reclaim_complete all
>> +    CODE: RECC1
>> +    """
>> +    c = env.c1.new_client(env.testname(t))
>> +    sess = c.create_session()
>> +
>> +    # RECLAIM_COMPLETE
>> +    res = sess.compound([op.putrootfh(), op.reclaim_complete(TRUE)])
>> +    check(res)
>> +
>> +    res = sess.compound([op.reclaim_complete(FALSE)])
>> +    check(res)
>> -- 
>> 1.7.6
>>
>>
> 
>