Return-Path: Received: from fieldses.org ([174.143.236.118]:38020 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751237Ab1IGUTI (ORCPT ); Wed, 7 Sep 2011 16:19:08 -0400 Date: Wed, 7 Sep 2011 16:18:13 -0400 From: "J. Bruce Fields" To: "Aneesh Kumar K.V" Cc: Steven Whitehouse , agruen@kernel.org, akpm@linux-foundation.org, dhowells@redhat.com, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -V6 00/26] New ACL format for better NFSv4 acl interoperability Message-ID: <20110907201813.GD8074@fieldses.org> References: <1315243548-18664-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1315302066.2741.12.camel@menhir> <87obyxdb6s.fsf@skywalker.in.ibm.com> Content-Type: text/plain; charset=us-ascii In-Reply-To: <87obyxdb6s.fsf@skywalker.in.ibm.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On Tue, Sep 06, 2011 at 07:28:51PM +0530, Aneesh Kumar K.V wrote: > On Tue, 06 Sep 2011 10:41:06 +0100, Steven Whitehouse wrote: > > Hi, > > > > On Mon, 2011-09-05 at 22:55 +0530, Aneesh Kumar K.V wrote: > > > Hi, > > > > > > The following set of patches implements VFS and ext4 changes needed to implement > > > a new acl model for linux. Rich ACLs are an implementation of NFSv4 ACLs, > > > extended by file masks to fit into the standard POSIX file permission model. > > > They are designed to work seamlessly locally as well as across the NFSv4 and > > > CIFS/SMB2 network file system protocols. > > > > > > A user-space utility for displaying and changing richacls is available at [4] > > > (a number of examples can be found at http://acl.bestbits.at/richacl/examples.html). > > > > > > [4] git://git.kernel.org/pub/scm/fs/acl/kvaneesh/richacl.git master > > > > > > To test richacl on ext4 use -o richacl mount option. This mount option may later be > > > dropped in favour of a feature flag. > > > > > > More details regarding richacl can be found at > > > http://acl.bestbits.at/richacl/ > > > > > > Changes from v5: > > > a) rebase to v3.1-rc4-131-g9e79e3e > > > > > > NOTE: The kernel changes will be pushed to > > > git://git.kernel.org/pub/scm/linux/kernel/git/kvaneesh/linux-richacl.git richacl > > > when kernel.org is back > > > > > > -aneesh > > > > > > > This looks like a really nice patch set. One question though is whether > > there are any test suites which can be used to gain confidence in the > > implementation? Obviously there is a fair amount of change here which > > has security implications, so it would be good to have some test results > > to go along with the patches, > > You can find the tests at > > http://git.kernel.org/?p=fs/acl/kvaneesh/richacl.git;a=tree;f=test;h=3bedf00ac69c79ae7a433996e729d4afb366b229;hb=HEAD Do you have a copy of that anywhere else? gitweb on kernel.org seems to be out at the moment. --b.