Return-Path: Received: from mx2.netapp.com ([216.240.18.37]:6464 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752329Ab1IZVcd convert rfc822-to-8bit (ORCPT ); Mon, 26 Sep 2011 17:32:33 -0400 Subject: Re: [PATCH] VFS: Suppress automount on [l]stat, [l]getxattr, etc. From: Trond Myklebust To: Linus Torvalds Cc: Ian Kent , Jeff Layton , Miklos Szeredi , David Howells , viro@zeniv.linux.org.uk, gregkh@suse.de, linux-nfs@vger.kernel.org, leonardo.lists@gmail.com Date: Mon, 26 Sep 2011 17:31:58 -0400 In-Reply-To: References: <1316747758.3346.89.camel@perseus.themaw.net> <20110922134510.24683.14576.stgit@warthog.procyon.org.uk> <1316707443.3346.44.camel@perseus.themaw.net> <1316709935.3346.48.camel@perseus.themaw.net> <20110922133529.6d3ea8de@barsoom.rdu.redhat.com> <20110922144453.6cf53a25@barsoom.rdu.redhat.com> <1316719228.3968.14.camel@lade.trondhjem.org> <2E1EB2CF9ED1CB4AA966F0EB76EAB4430B480BD4@SACMVEXC2-PRD.hq.netapp.com> <21772.1316774025@redhat.com> <1316788444.14812.10.camel@lade.trondhjem.org> <29743.1316791138@redhat.com> <87hb43tf2g.fsf@tucsk.pomaz.szeredi.hu> <1316827854.3346.154.camel@perseus.themaw.net> <20110924073610.4b045189@tlielax.poochiereds.net> <1317013864.3187.81.camel@perseus.themaw.net> <1317071626.19951.8.camel@lade.trondhjem.org> Content-Type: text/plain; charset="UTF-8" Message-ID: <1317072718.19951.13.camel@lade.trondhjem.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On Mon, 2011-09-26 at 14:24 -0700, Linus Torvalds wrote: > On Mon, Sep 26, 2011 at 2:13 PM, Trond Myklebust > wrote: > > > > LOOKUP_OPEN flags an open intent and will therefore have side-effects on > > NFSv4. > > Yes, and the actual downside for that is exactly what? > > If you are talking about the bind mount issue, then what is the > downside with saying "we want the same stronger consistency guarantees > as for a 'file open' operation"? A bind mount doesn't actually want us to set up OPEN state on the NFSv4 server and return a fully initialised 'struct file' in the struct nameidata. If it did, we would already have set the LOOKUP_OPEN flag together with the accompanying open intent structure in the struct nameidata. Ditto for the quotactl(). Cheers Trond -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@netapp.com www.netapp.com