Return-Path: Received: from e1.ny.us.ibm.com ([32.97.182.141]:44840 "EHLO e1.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758127Ab1IHJgO (ORCPT ); Thu, 8 Sep 2011 05:36:14 -0400 Received: from /spool/local by us.ibm.com with XMail ESMTP for from ; Thu, 8 Sep 2011 05:36:13 -0400 From: "Aneesh Kumar K.V" To: "J. Bruce Fields" Cc: agruen@kernel.org, akpm@linux-foundation.org, dhowells@redhat.com, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -V6 11/26] vfs: Add permission flags for setting file attributes In-Reply-To: <20110907205503.GG8074@fieldses.org> References: <1315243548-18664-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1315243548-18664-12-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <20110907205503.GG8074@fieldses.org> Date: Thu, 08 Sep 2011 15:06:03 +0530 Message-ID: <87d3fb5qbg.fsf@skywalker.in.ibm.com> Content-Type: text/plain; charset=us-ascii Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On Wed, 7 Sep 2011 16:55:03 -0400, "J. Bruce Fields" wrote: > On Mon, Sep 05, 2011 at 10:55:33PM +0530, Aneesh Kumar K.V wrote: > > From: Andreas Gruenbacher > > > > Some permission models can allow processes to take ownership of a file, > > change the file permissions, and set the file timestamps. Introduce new > > permission mask flags and check for those permissions in > > inode_change_ok(). > > These little helper functions seem like they might be reasonable cleanup > even without the richacl_change_ok() piece; wonder if it'd be worth > splitting out the cleanup and applying it now? > > Not that it's necessary--seems like a straightforward enough patch as > is. Those helpers also have richacl_chage_ok(..) done as a part of the call. So they cannot directly be applied to upstream. But we can do similar helpers for upstream and add richacl changes as a separate patch ? Is that what you are suggesting. I can split this patch to two in that case -aneesh