Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:61872 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750736Ab1IVPX2 convert rfc822-to-8bit (ORCPT ); Thu, 22 Sep 2011 11:23:28 -0400 Date: Thu, 22 Sep 2011 11:26:36 -0400 From: Jeff Layton To: Linus Torvalds Cc: David Howells , miklos@szeredi.hu, raven@themaw.net, viro@zeniv.linux.org.uk, gregkh@suse.de, linux-nfs@vger.kernel.org, leonardo.lists@gmail.com Subject: Re: [PATCH] NFS4: Revert commit to make the automount code ignore LOOKUP_FOLLOW Message-ID: <20110922112636.05f9fc9a@barsoom.rdu.redhat.com> In-Reply-To: References: <20110922124608.7739.27750.stgit@warthog.procyon.org.uk> Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On Thu, 22 Sep 2011 07:33:43 -0700 Linus Torvalds wrote: > On Thu, Sep 22, 2011 at 5:46 AM, David Howells wrote: > > > >  (4) Add a new flag, say LOOKUP_GETTING_ATTRS, to indicate that we're doing a > >     stat() or a getxattr() and suppress automounting on that basis. > > I'd prefer this one. Except I'd just call it LOOKUP_STAT to make it > less cumbersome. > > And then just have lstat/stat/xattr set that bit, and make it clear > that that bit means "no automount". > Maybe LOOKUP_NO_AUTOMOUNT would be better in that case? -- Jeff Layton