Return-Path: linux-nfs-owner@vger.kernel.org Received: from idcmail-mo2no.shaw.ca ([64.59.134.9]:28451 "EHLO idcmail-mo2no.shaw.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751474Ab1JRSlR convert rfc822-to-8bit (ORCPT ); Tue, 18 Oct 2011 14:41:17 -0400 Subject: Re: [PATCH -V7 25/26] ext4: Implement rich acl for ext4 Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Andreas Dilger In-Reply-To: <1318951981-5508-26-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Date: Tue, 18 Oct 2011 12:41:15 -0600 Cc: agruen@kernel.org, bfields@fieldses.org, akpm@linux-foundation.org, viro@zeniv.linux.org.uk, dhowells@redhat.com, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: References: <1318951981-5508-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1318951981-5508-26-git-send-email-aneesh.kumar@linux.vnet.ibm.com> To: "Aneesh Kumar K.V" Sender: linux-nfs-owner@vger.kernel.org List-ID: On 2011-10-18, at 9:33 AM, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" > > Support the richacl permission model in ext4. The richacls are stored > in "system.richacl" xattrs.This need to be enabled by tune2fs or during > mkfs.ext4 It isn't clear from your commit comment or the code what needs to be enabled by tune2fs or mkfs.ext4. Please list the specific ext4 feature that needs to be enabled. > +#ifdef CONFIG_EXT4_FS_RICHACL > +#define EXT4_IS_RICHACL(inode) IS_RICHACL(inode) > > +#else /* CONFIG_FS_EXT4_RICHACL */ > + > +#define EXT4_IS_RICHACL(inode) (0) It is a bit confusing that you are using both EXT4_IS_RICHACL() and IS_RICHACL() in this code. Initially I thought EXT4_IS_RICHACL() was checking an ext4-specific inode flag, but it seems that it is instead conditional upon the configure flags. It looks like it should be possible to use EXT4_IS_RICHACL() in all of the code, since the richacl-specific code will not be compiled anyway. Cheers, Andreas