Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx2.netapp.com ([216.240.18.37]:65051 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756430Ab1JMRT4 convert rfc822-to-8bit (ORCPT ); Thu, 13 Oct 2011 13:19:56 -0400 Subject: Re: [PATCH] nfs-utils: mount: really return from errno test From: Trond Myklebust To: Steve Dickson Cc: Chuck Lever , Hamo , linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 13 Oct 2011 13:19:55 -0400 In-Reply-To: <4E9718E3.8040805@RedHat.com> References: <40D1A40C-BE0C-4AE0-857D-05531615748E@oracle.com> <4E971329.3000007@RedHat.com> <4E9718E3.8040805@RedHat.com> Content-Type: text/plain; charset="UTF-8" Message-ID: <1318526395.4773.20.camel@lade.trondhjem.org> Mime-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org List-ID: This is by design. NFSv3 and NFSv4 have no server-side identifiers to inform us that we may be talking to the same server, and so we don't worry about doing so. An NFSv4.1 server can tell you that this is the same server replying on different IP addresses. We are planning on adding proper support for that, but I don't believe we've currently got it right. Cheers Trond On Thu, 2011-10-13 at 12:59 -0400, Steve Dickson wrote: > Looking further into this issue, I noticed all the following > mounts were successful. > > # mount -o v3 localhost:/home /mnt/home > # mount -o v4 localhost:/home /mnt/home > # mount -o v4 [fec0::2:5652:ff:fe20:8459]:/home /mnt/home > # mount -o v3 [fec0::2:5652:ff:fe20:8459]:/home /mnt/home > > which the mount point, /mnt/home is mounted 4 different times > to the same server. > > Is by design or a real problem? > > steved. > > > On 10/13/2011 12:34 PM, Steve Dickson wrote: > > Yeah... I believe its this one > > https://bugzilla.redhat.com/show_bug.cgi?id=744657 > > > > On 10/13/2011 10:53 AM, Chuck Lever wrote: > >> What was the presenting problem? Is there a bugzilla report I can look at? > >> > >> On Oct 11, 2011, at 5:44 AM, Hamo wrote: > >> > >>> We should only try next address family if we meet ECONNREFUSED or EHOSTUNREACH > >>> for v4 or ECONNREFUSED or EOPNOTSUPP or EHOSTUNREACH for v3v2. > >>> Before, only a break in swich can not make the program out of for loop. > >>> > >>> Signed-off-by: Yang Bai > >>> --- > >>> utils/mount/stropts.c | 6 ++++-- > >>> 1 files changed, 4 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c > >>> index 314a806..4032bf3 100644 > >>> --- a/utils/mount/stropts.c > >>> +++ b/utils/mount/stropts.c > >>> @@ -665,9 +665,10 @@ static int nfs_try_mount_v3v2(struct nfsmount_info *mi) > >>> case EHOSTUNREACH: > >>> continue; > >>> default: > >>> - break; > >>> + goto out; > >>> } > >>> } > >>> +out: > >>> return ret; > >>> } > >>> > >>> @@ -751,9 +752,10 @@ static int nfs_try_mount_v4(struct nfsmount_info *mi) > >>> case EHOSTUNREACH: > >>> continue; > >>> default: > >>> - break; > >>> + goto out; > >>> } > >>> } > >>> +out: > >>> return ret; > >>> } > >>> > >>> -- > >>> 1.7.1 > >>> -- > >>> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > >>> the body of a message to majordomo@vger.kernel.org > >>> More majordomo info at http://vger.kernel.org/majordomo-info.html > >> > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@netapp.com www.netapp.com