Return-Path: linux-nfs-owner@vger.kernel.org Received: from acsinet15.oracle.com ([141.146.126.227]:30662 "EHLO acsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753283Ab1JMOxT convert rfc822-to-8bit (ORCPT ); Thu, 13 Oct 2011 10:53:19 -0400 Subject: Re: [PATCH] nfs-utils: mount: really return from errno test Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Chuck Lever In-Reply-To: Date: Thu, 13 Oct 2011 10:53:05 -0400 Cc: linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: <40D1A40C-BE0C-4AE0-857D-05531615748E@oracle.com> References: To: Hamo Sender: linux-nfs-owner@vger.kernel.org List-ID: What was the presenting problem? Is there a bugzilla report I can look at? On Oct 11, 2011, at 5:44 AM, Hamo wrote: > We should only try next address family if we meet ECONNREFUSED or EHOSTUNREACH > for v4 or ECONNREFUSED or EOPNOTSUPP or EHOSTUNREACH for v3v2. > Before, only a break in swich can not make the program out of for loop. > > Signed-off-by: Yang Bai > --- > utils/mount/stropts.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c > index 314a806..4032bf3 100644 > --- a/utils/mount/stropts.c > +++ b/utils/mount/stropts.c > @@ -665,9 +665,10 @@ static int nfs_try_mount_v3v2(struct nfsmount_info *mi) > case EHOSTUNREACH: > continue; > default: > - break; > + goto out; > } > } > +out: > return ret; > } > > @@ -751,9 +752,10 @@ static int nfs_try_mount_v4(struct nfsmount_info *mi) > case EHOSTUNREACH: > continue; > default: > - break; > + goto out; > } > } > +out: > return ret; > } > > -- > 1.7.1 > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Chuck Lever chuck[dot]lever[at]oracle[dot]com