Message-ID: <1321655828.10541.23.camel@lade.trondhjem.org>
Subject: Re: [PATCH] Add "-e" option to rpc.gssd to allow error on ticket
 expiry. Try 2 with added man pages.
From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: John Hughes <john@calvaedi.com>
Cc: Jim Rees <rees@umich.edu>, John Hughes <john@Calva.COM>,
        linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Sat, 19 Nov 2011 00:37:08 +0200
In-Reply-To: <4EC6DD4D.1010008@calvaedi.com>
References: <4EC66D12.2090505@Calva.COM>
		 <1321641333.2653.15.camel@lade.trondhjem.org>
		 <4EC6AFA9.9000705@calvaedi.com>
		 <1321648435.2653.53.camel@lade.trondhjem.org>
		 <20111118205749.GA1680@umich.edu>
	 <1321650239.2653.68.camel@lade.trondhjem.org>
	 <4EC6DD4D.1010008@calvaedi.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Sender: linux-nfs-owner@vger.kernel.org

On Fri, 2011-11-18 at 23:33 +0100, John Hughes wrote: 
> On 11/18/2011 10:03 PM, Trond Myklebust wrote:
> > On Fri, 2011-11-18 at 15:57 -0500, Jim Rees wrote:
> >    
> >>
> >> The write() syscall doesn't indicate whether the data is safe or not.  That
> >> would be the close() syscall.
> >>      
> > fsync(). Which may succeed if the user renews their ticket first.
> > However you may still have data loss if dirty data has been lost because
> > of EKEYEXPIRED returns on the WRITE RPC call...
> >    
> Only if the write(2) returned EKEYEXPIRED, surely,

What part of "write is asynchronous" is so hard to understand?

> > Also, for the fsync() to return EKEYEXPIRED _after_ the user has renewed
> > their ticket would seem counter-intuitive to most people.
> >    
> 
> I would want to know if data was lost.
> 
> Intuition means nothing if I get an error.
> 
> If it were possible I'd like:
> 
> 1. write works
> 1a. WRITE RPC fails, data stays in cache
> 2. ticket renewed
> 3. fsync works, data written

Which is _exactly_ how it works today, so what is the problem?

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com