MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Subject: RE: [PATCH (resend) Version 2 3/3] NFSv4.1: fix backchennel bug
Date: Fri, 4 Nov 2011 07:34:39 -0700
Message-ID: <2E1EB2CF9ED1CB4AA966F0EB76EAB4430BFA925E@SACMVEXC2-PRD.hq.netapp.com>
References: <1318919979-14606-1-git-send-email-andros@netapp.com> 
From: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
To: "Adamson, Andy" <William.Adamson@netapp.com>
Cc: <linux-nfs@vger.kernel.org>
Sender: linux-nfs-owner@vger.kernel.org

> -----Original Message-----
> From: Myklebust, Trond
> Sent: Friday, November 04, 2011 10:32 AM
> To: Adamson, Andy
> Cc: linux-nfs@vger.kernel.org
> Subject: RE: [PATCH (resend) Version 2 3/3] NFSv4.1: fix backchennel
bug
> 
> > -----Original Message-----
> > From: Adamson, Andy
> > Sent: Tuesday, October 18, 2011 2:40 AM
> > To: Myklebust, Trond
> > Cc: linux-nfs@vger.kernel.org; Adamson, Andy
> > Subject: [PATCH (resend) Version 2 3/3] NFSv4.1: fix backchennel bug
> >
> > From: Andy Adamson <andros@netapp.com>
> >
> > Slotid's start from 0 which means we check against
> > NFS41_BC_MAX_CALLBACKS - 1.
> >
> > Signed-off-by: Andy Adamson <andros@netapp.com>
> > ---
> >  fs/nfs/callback_proc.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/fs/nfs/callback_proc.c b/fs/nfs/callback_proc.c index
> > 98ff5fc..12bd9d0 100644
> > --- a/fs/nfs/callback_proc.c
> > +++ b/fs/nfs/callback_proc.c
> > @@ -339,7 +339,7 @@ validate_seqid(struct nfs4_slot_table *tbl,
struct
> > cb_sequenceargs * args)
> >  	dprintk("%s enter. slotid %d seqid %d\n",
> >  		__func__, args->csa_slotid, args->csa_sequenceid);
> >
> > -	if (args->csa_slotid > NFS41_BC_MAX_CALLBACKS)
> > +	if (args->csa_slotid > NFS41_BC_MAX_CALLBACKS - 1)
> >  		return htonl(NFS4ERR_BADSLOT);
> 
> Why not just replace '>' with '>='?

BTW: Shouldn't this patch be 1/3 and be Cc: stable@vger.kernel.org? It
looks as if it ought to be backported to the stable kernels...